Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E68C1D066 for ; Wed, 27 Feb 2013 18:02:38 +0000 (UTC) Received: (qmail 45246 invoked by uid 500); 27 Feb 2013 18:02:38 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 45140 invoked by uid 500); 27 Feb 2013 18:02:38 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 45128 invoked by uid 99); 27 Feb 2013 18:02:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Feb 2013 18:02:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 552261C7A7F; Wed, 27 Feb 2013 18:02:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2155375972528504964==" MIME-Version: 1.0 Subject: Re: Review Request: Support for VHDX image format, and update to RegisterTemplate UI to support Hyper-V 2012 From: "Chip Childers" To: "Animesh Chaturvedi" , "Chiradeep Vittal" Cc: "Chip Childers" , "cloudstack" , "Donal Lafferty" Date: Wed, 27 Feb 2013 18:02:30 -0000 Message-ID: <20130227180230.17326.4017@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chip Childers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9444/ X-Sender: "Chip Childers" References: <20130220195220.18987.95159@reviews.apache.org> In-Reply-To: <20130220195220.18987.95159@reviews.apache.org> Reply-To: "Chip Childers" --===============2155375972528504964== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9444/#review17152 ----------------------------------------------------------- I think this review was useful to get feedback on the code itself, but we d= on't want to apply the patch as-is. Chiradeep's comments explain why. Can we please close this review out now as discarded (until Hyper-V is brou= ght into the project)? - Chip Childers On Feb. 20, 2013, 7:52 p.m., Donal Lafferty wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9444/ > ----------------------------------------------------------- > = > (Updated Feb. 20, 2013, 7:52 p.m.) > = > = > Review request for cloudstack, Chiradeep Vittal and Animesh Chaturvedi. > = > = > Description > ------- > = > Add support for VHDX image type, and allow UI for RegisterTemplate to sup= port both Hyper-V image types. > = > = > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1032. > = > = > Diffs > ----- > = > api/src/com/cloud/storage/Storage.java fba12b6 = > server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe = > server/src/com/cloud/template/HyervisorTemplateAdapter.java 089f650 = > ui/scripts/templates.js 040ce4a = > = > Diff: https://reviews.apache.org/r/9444/diff/ > = > = > Testing > ------- > = > Integration test on code when built for Hyper-V Phase 1 fork. > = > Not clear what unit tests can be updated to walk the code. > = > = > Thanks, > = > Donal Lafferty > = > --===============2155375972528504964==--