Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============4352862502642174869=="
MIME-Version: 1.0
Subject: Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch
 in
 CloudStack'.
From: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>
To: "Murali Reddy" <muralimmreddy@gmail.com>,
 "Kelven Yang" <kelven.yang@citrix.com>
Cc: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>
Date: Wed, 27 Feb 2013 13:12:00 -0000
Message-ID: <20130227131200.17326.90602@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sateesh Chodapuneedi" <noreply@reviews.apache.org>
References: <20130226080938.1281.27914@reviews.apache.org>
In-Reply-To: <20130226080938.1281.27914@reviews.apache.org>
Reply-To: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>

--===============4352862502642174869==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/#review17148
-----------------------------------------------------------

Ship it!


Ship It!

- Sateesh Chodapuneedi


On Feb. 26, 2013, 8:09 a.m., Sateesh Chodapuneedi wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9210/
> -----------------------------------------------------------
> =

> (Updated Feb. 26, 2013, 8:09 a.m.)
> =

> =

> Review request for cloudstack, Murali Reddy and Kelven Yang.
> =

> =

> Description
> -------
> =

> This is 5/final patch for feature 'Support for VMware dvSwitch in CloudSt=
ack'.
> =

> This patch contains =

> 1)Changes to addCluster done in vmware discoverer to support vswitch type=
 provided as parameters. Also performing validation of vswitch type paramet=
er provided with addCluster api call. Physical network configuration is val=
idated.
> 2)Changes to vmware resource to use specified vswitch type while preparin=
g network for guest and public traffic types
> 3)Changes to vmware manager to introduce new global parameter vmware.port=
s.per.dvportgroup. Some cleanup.
> Virtual switch type could be chosen at zone level or at cluster level for=
 specific traffic type. autoExpand of dvPortGroup is available in code but =
disabled as its breaking because vCenter 4.1 does not support autoExpand fe=
ature. This would be supported once vSphere SDK 5.1 is added to CloudStack.
> =

> =

> This addresses bug CLOUDSTACK-657.
> =

> =

> Diffs
> -----
> =

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServer=
Discoverer.java 5d7edce =

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmwa=
reManager.java 36fa0f3 =

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmwa=
reManagerImpl.java a0d9943 =

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/Vmw=
areResource.java 4839b35 =

>   server/src/com/cloud/resource/ResourceManagerImpl.java 14628c1 =

>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.jav=
a 50f9541 =

> =

> Diff: https://reviews.apache.org/r/9210/diff/
> =

> =

> Testing
> -------
> =

> Testing
> -------
> =

> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In=
 this case management and public traffic uses standard vSwitch on a common =
physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physic=
al network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level =
network traffic label. Tested 2 clusters, one with standard vSwitch and oth=
er with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global para=
meter 'vmware.use.dvswitch' set to false. This is default configuration sce=
nario.
> =

> =

> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> =

> =

> Thanks,
> =

> Sateesh Chodapuneedi
> =

>


--===============4352862502642174869==--