Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============4051302091825168973=="
MIME-Version: 1.0
Subject: Re: Review Request: Patch1 for feature - (CLOUDSTACK-657) VMware
 vNetwork
 Distributed Virtual Switch support in CloudStack
From: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>
To: "Murali Reddy" <muralimmreddy@gmail.com>,
 "Kelven Yang" <kelven.yang@citrix.com>
Cc: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Koushik Das" <koushik.das@citrix.com>
Date: Mon, 25 Feb 2013 11:14:29 -0000
Message-ID: <20130225111429.1280.20763@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sateesh Chodapuneedi" <noreply@reviews.apache.org>
References: <20130207003319.13218.71574@reviews.apache.org>
In-Reply-To: <20130207003319.13218.71574@reviews.apache.org>
Reply-To: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>

--===============4051302091825168973==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9189/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 11:14 a.m.)


Review request for cloudstack, Murali Reddy and Kelven Yang.


Changes
-------

Updated traffic label processing to accept type of vswitch to decide defaul=
t configuration parameters when label is not specified.


Description
-------

This is 1st patch for feature 'Support for VMware dvSwitch in CloudStack'.
This contains 3 newly introduced classes. Added apache license header for a=
ll 3 files.
[1]TrafficLable and [2]VmwareTrafficLabel classes are to define and encapsu=
late virtual switch type per traffic type along with other network label fi=
elds (VLAN ID and physical network).
[3]DistributedVirtualSwitchMO class is wrapper class for vSphere API calls =
specific to a distributed virtual switch in a vCenter datacenter.
Feature highlights:
Virtual switch type could be chosen at zone level or at cluster level for s=
pecific traffic type. All virtual network orchestration would use the speci=
fied virtual switch. So far CloudStack could use only vSwitch of type stand=
ard vSwitch, with this feature CloudStack can use VMware dvSwitch as well. =
Support for VMware dvSwitch is available for guest and public traffic types.
autoExpand of dvPortGroup is available in code but disabled as its breaking=
 because vCenter 4.1 does not support autoExpand feature.


This addresses bug CLOUDSTACK-657.


Diffs (updated)
-----

  api/src/com/cloud/network/TrafficLabel.java PRE-CREATION =

  plugins/hypervisors/vmware/src/com/cloud/network/VmwareTrafficLabel.java =
PRE-CREATION =

  vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO=
.java PRE-CREATION =


Diff: https://reviews.apache.org/r/9189/diff/


Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In t=
his case management and public traffic uses standard vSwitch on a common ph=
ysical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical=
 network.
3) Use optional parameters added to AddClusterCmd to override Zone level ne=
twork traffic label. Tested 2 clusters, one with standard vSwitch and other=
 with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parame=
ter 'vmware.use.dvswitch' set to false. This is default configuration scena=
rio.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi


--===============4051302091825168973==--