Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7138EED48 for ; Sat, 23 Feb 2013 02:06:08 +0000 (UTC) Received: (qmail 97133 invoked by uid 500); 23 Feb 2013 02:06:08 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 97091 invoked by uid 500); 23 Feb 2013 02:06:07 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 97074 invoked by uid 99); 23 Feb 2013 02:06:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Feb 2013 02:06:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ECB481C79CA; Sat, 23 Feb 2013 02:05:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8952525089342288954==" MIME-Version: 1.0 Subject: Re: Review Request: Provide customizable instance names for guest VMs in cloudstack From: "Venkata Siva Vijayendra Bhamidipati" To: "Frank Zhang" , "Kelven Yang" Cc: "Wei Zhou" , "Koushik Das" , "Venkata Siva Vijayendra Bhamidipati" , "cloudstack" Date: Sat, 23 Feb 2013 02:05:59 -0000 Message-ID: <20130223020559.18986.91484@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Venkata Siva Vijayendra Bhamidipati" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9202/ X-Sender: "Venkata Siva Vijayendra Bhamidipati" References: <20130131192133.24984.23503@reviews.apache.org> In-Reply-To: <20130131192133.24984.23503@reviews.apache.org> Reply-To: "Venkata Siva Vijayendra Bhamidipati" --===============8952525089342288954== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9202/ ----------------------------------------------------------- (Updated Feb. 23, 2013, 2:05 a.m.) Review request for cloudstack, Kelven Yang and Frank Zhang. Changes ------- Uploading a consolidated diff incorporating latest review comments, that ca= n be applied on top of master. Description ------- Patch to allow user to append display name to internal instance name of gue= st VMs on cloudstack during guest VM creation. This addresses bug CS-778. Diffs (updated) ----- server/src/com/cloud/configuration/Config.java 8c77715 = server/src/com/cloud/vm/UserVmManagerImpl.java cf9eb27 = server/src/com/cloud/vm/dao/VMInstanceDao.java d34b257 = server/src/com/cloud/vm/dao/VMInstanceDaoImpl.java 531c794 = setup/db/db/schema-410to420.sql 4637b6d = Diff: https://reviews.apache.org/r/9202/diff/ Testing ------- Manual Testing: Set the global parameter vm.instancename.flag to true, restart mgmt server,= create a guest VM and provide a display Name value when doing so. The vm c= reated will have its internal name in the form of i-<>-<>-displayname. Set the global parameter vm.instancename.flag back to false, restart mgmt s= erver, and create a guest VM providing the display Name. The vm created wil= l have the internal name in the form of i-<>-<> If no display name is provided during instance creation, the vm internal na= me will be in the form of i-<>-<>. Thanks, Venkata Siva Vijayendra Bhamidipati --===============8952525089342288954==--