Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============1899390786650903798=="
MIME-Version: 1.0
Subject: Re: Review Request: Support for full clones on ESX for Cloudstack
 (CS-670)
From: "Frank Zhang" <frank.zhang@citrix.com>
To: "Kelven Yang" <kelven.yang@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidipati@citrix.com>,
 "Frank Zhang" <frank.zhang@citrix.com>
Date: Fri, 22 Feb 2013 19:12:03 -0000
Message-ID: <20130222191203.18986.21138@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Frank Zhang" <noreply@reviews.apache.org>
References: <20130222020847.18987.61564@reviews.apache.org>
In-Reply-To: <20130222020847.18987.61564@reviews.apache.org>
Reply-To: "Frank Zhang" <frank.zhang@citrix.com>

--===============1899390786650903798==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On Feb. 22, 2013, 2:08 a.m., Kelven Yang wrote:
> > Ship It!

cannot apply patch, it diversify much that current 4.1 branch. please rebas=
e and summit again


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16918
-----------------------------------------------------------


On Feb. 15, 2013, 8:47 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> =

> (Updated Feb. 15, 2013, 8:47 p.m.)
> =

> =

> Review request for cloudstack and Kelven Yang.
> =

> =

> Description
> -------
> =

> Please find the diffs for full clone guest VM support for ESX on Cloudsta=
ck. The diffs do not include unit tests yet. The tests will be uploaded at =
the earliest.
> =

> =

> This addresses bug CS-670.
> =

> =

> Diffs
> -----
> =

>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff =

>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CRE=
ATION =

>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.jav=
a PRE-CREATION =

>   server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION =

> =

> Diff: https://reviews.apache.org/r/9439/diff/
> =

> =

> Testing
> -------
> =

> Manual Testing
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =

> Creation of guest VMs when the global flag vmware.create.full.clone is se=
t to its default value of false will create those guest VMs as linked clone=
s (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is se=
t to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the=
 cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and=
 work as expected.
> =

> =

> Thanks,
> =

> Venkata Siva Vijayendra Bhamidipati
> =

>


--===============1899390786650903798==--