Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56609E05B for ; Wed, 20 Feb 2013 11:04:02 +0000 (UTC) Received: (qmail 98568 invoked by uid 500); 20 Feb 2013 11:04:01 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 98535 invoked by uid 500); 20 Feb 2013 11:04:01 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 98503 invoked by uid 99); 20 Feb 2013 11:04:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Feb 2013 11:04:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B3DFC1C6A04; Wed, 20 Feb 2013 11:03:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7595761585739534743==" MIME-Version: 1.0 Subject: Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level. From: "Abhinandan Prateek" To: "Prachi Damle" , "Abhinandan Prateek" , "Nitin Mehta" Cc: "bharat kumar" , "Sateesh Chodapuneedi" , "cloudstack" Date: Wed, 20 Feb 2013 11:03:53 -0000 Message-ID: <20130220110353.18986.41789@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Abhinandan Prateek" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9156/ X-Sender: "Abhinandan Prateek" References: <20130219080634.18986.69486@reviews.apache.org> In-Reply-To: <20130219080634.18986.69486@reviews.apache.org> Reply-To: "Abhinandan Prateek" --===============7595761585739534743== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Feb. 19, 2013, 8:06 a.m., Sateesh Chodapuneedi wrote: > > vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java, lin= e 543 > > > > > > Memory & CPU host add would be dependent on following cases. > > 1) OS type > > 2) Host License > > If either or both of above doesn't support memory / CPU hot add tha= t would result in vm reconfiguration failure. This would block VM deploymen= t. > > Need to handle this. Since enabling and disabling DMC is outside cloudstack control we in some s= ituation will not know that DMC has changed. We can though document this fa= ct and have the admin ensure that his cluster should support DMC if he is g= oing to use it. We should also clarify this issue in an update to community and document = the above as prerequisite in FS. - Abhinandan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9156/#review16735 ----------------------------------------------------------- On Feb. 18, 2013, 4:10 p.m., bharat kumar wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9156/ > ----------------------------------------------------------- > = > (Updated Feb. 18, 2013, 4:10 p.m.) > = > = > Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Niti= n Mehta. > = > = > Description > ------- > = > This patch enables cpu and ram overcommit on a per cluster basis(only for= xenserver.). > The dashboard will show actual values instead of the overcommit values. > = > = > This addresses bug CLOUDSTACK-711. > = > = > Diffs > ----- > = > api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb = > api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443 = > api/src/org/apache/cloudstack/api/ApiConstants.java d29408e = > api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.j= ava 912c396 = > api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530 = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtCo= mputingResource.java 552afb1 = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVM= Def.java acfd9cf = > plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManager= Impl.java 60e1a61 = > plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResour= ce.java 721e5f7 = > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmwa= reManagerImpl.java 88e03f5 = > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/Vmw= areResource.java 841a535 = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixRes= ourceBase.java c7ff5c7 = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer= Resource.java 0ce91bc = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer= 56FP1Resource.java 58b8a03 = > server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.jav= a a25e401 = > server/src/com/cloud/api/ApiDBUtils.java 83132c6 = > server/src/com/cloud/api/ApiResponseHelper.java 8c97615 = > server/src/com/cloud/capacity/CapacityManager.java fffb41f = > server/src/com/cloud/capacity/CapacityManagerImpl.java d7b7053 = > server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a = > server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b = > server/src/com/cloud/capacity/dao/CapacityDaoImpl.java baaf391 = > server/src/com/cloud/deploy/BareMetalPlanner.java 829a466 = > server/src/com/cloud/deploy/FirstFitPlanner.java 66a24ac = > server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962 = > server/src/com/cloud/resource/ResourceManagerImpl.java 82013d4 = > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1838ed2 = > server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0 = > vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff= 8e2 = > = > Diff: https://reviews.apache.org/r/9156/diff/ > = > = > Testing > ------- > = > Did manual testing. > = > = > Thanks, > = > bharat kumar > = > --===============7595761585739534743==--