Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3739662640443809156=="
MIME-Version: 1.0
Subject: Re: Review Request: Support for full clones on ESX for Cloudstack
 (CS-670)
From: "Venkata Siva Vijayendra Bhamidipati"
 <vijayendra.bhamidipati@citrix.com>
To: "Kelven Yang" <kelven.yang@citrix.com>
Cc: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidipati@citrix.com>
Date: Fri, 15 Feb 2013 20:45:51 -0000
Message-ID: <20130215204551.9635.65880@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Venkata Siva Vijayendra Bhamidipati" <noreply@reviews.apache.org>
References: <20130215105627.9635.87453@reviews.apache.org>
In-Reply-To: <20130215105627.9635.87453@reviews.apache.org>
Reply-To: "Venkata Siva Vijayendra Bhamidipati"
 <vijayendra.bhamidipati@citrix.com>

--===============3739662640443809156==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/
-----------------------------------------------------------

(Updated Feb. 15, 2013, 8:45 p.m.)


Review request for cloudstack and Kelven Yang.


Changes
-------

Attempting to re-upload patch 3. Hopefully it will be readable via reviewbo=
ard. If not, please refer to the attached file.


Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack=
. The diffs do not include unit tests yet. The tests will be uploaded at th=
e earliest.


This addresses bug CS-670.


Diffs (updated)
-----

  server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff =

  server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREAT=
ION =

  server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java =
PRE-CREATION =

  server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION =


Diff: https://reviews.apache.org/r/9439/diff/


Testing
-------

Manual Testing
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Creation of guest VMs when the global flag vmware.create.full.clone is set =
to its default value of false will create those guest VMs as linked clones =
(current default behavior without these changes).
Creation of guest VMs when the global flag vmware.create.full.clone is set =
to true will create those guest VMs as full clones.
Appropriate entries are created in the user_vm_clone_setting table of the c=
loud schema to reflect the clone type of the VMs.
Linked clones and full clones can reside together in the same cluster and w=
ork as expected.


Thanks,

Venkata Siva Vijayendra Bhamidipati


--===============3739662640443809156==--