Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A0C19D84C for ; Thu, 14 Feb 2013 11:45:09 +0000 (UTC) Received: (qmail 23820 invoked by uid 500); 14 Feb 2013 11:45:08 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 23738 invoked by uid 500); 14 Feb 2013 11:45:07 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 23601 invoked by uid 99); 14 Feb 2013 11:45:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Feb 2013 11:45:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5B61E1C60DB; Thu, 14 Feb 2013 11:44:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6894816455290550651==" MIME-Version: 1.0 Subject: Re: Review Request: ignor unassignIPFromVpcNetwork in finally block of EnableStaticNat From: "Prasanna Santhanam" To: "Prasanna Santhanam" Cc: "cloudstack" , "Wei Zhou" Date: Thu, 14 Feb 2013 11:44:42 -0000 Message-ID: <20130214114442.21521.14276@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prasanna Santhanam" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9443/ X-Sender: "Prasanna Santhanam" References: <20130214110229.9635.1878@reviews.apache.org> In-Reply-To: <20130214110229.9635.1878@reviews.apache.org> Reply-To: "Prasanna Santhanam" --===============6894816455290550651== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9443/#review16575 ----------------------------------------------------------- Ship it! commit 0ec4217aae5cbfd7702c981fca524b77952b7ccc Author: Wei Zhou Date: Thu Feb 14 17:11:05 2013 +0530 ignore unassignIPFromVpcNetwork in finally block of EnableStaticNat - Prasanna Santhanam On Feb. 14, 2013, 11:02 a.m., Wei Zhou wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9443/ > ----------------------------------------------------------- > = > (Updated Feb. 14, 2013, 11:02 a.m.) > = > = > Review request for cloudstack and Prasanna Santhanam. > = > = > Description > ------- > = > This patch only applies on 4.0, not on master(!) > = > unassignIPFromVpcNetwork processing should not execute when EnableStaticN= at succeed. > Without this patch, unassignIPFromVpcNetwork will execute whenever Enable= StaticNat is successful or failed. > = > This is because of the inconsistent of patch of CLOUDSACK-1211 (https://r= eviews.apache.org/r/9384/ ). > In master, it is ok. https://git-wip-us.apache.org/repos/asf?p=3Dincubato= r-cloudstack.git;a=3Dcommitdiff;h=3D2e2ee2f;hp=3D8234dfa544625cd300559a7380= fee7e9828870f8 > In 4.0, it is different. https://git-wip-us.apache.org/repos/asf?p=3Dincu= bator-cloudstack.git;a=3Dcommitdiff;h=3Da61a2b1;hp=3D19d5f39c579676e59f4b83= eb5da3eddef230ff97 > = > = > Diffs > ----- > = > server/src/com/cloud/network/rules/RulesManagerImpl.java 6c1e27a = > = > Diff: https://reviews.apache.org/r/9443/diff/ > = > = > Testing > ------- > = > Testing OK. > = > = > Thanks, > = > Wei Zhou > = > --===============6894816455290550651==--