Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of srivatsav.prasanna@gmail.com
 designates 209.85.215.169 as permitted sender)
Sender: prasanna <srivatsav.prasanna@gmail.com>
Date: Thu, 14 Feb 2013 15:13:11 +0530
From: Prasanna Santhanam <tsp@apache.org>
To: "cloudstack-dev@incubator.apache.org"
 <cloudstack-dev@incubator.apache.org>
Subject: Re: [DISCUSS][INFRA] Setting up gerrit
Message-ID: <20130214094311.GB4564@cloud-2.local>
Mail-Followup-To: "cloudstack-dev@incubator.apache.org"
 <cloudstack-dev@incubator.apache.org>
References: 
 <B1DF26ECC0458748AC97CECE2DA98D41012FA4A70644@SJCPMAILBOX01.citrite.net>
 <53628857-87F4-4CC1-9FF5-3C45C0882BCC@stratosec.co>
 <1360598677.2729.140661189880901.7AB46155@webmail.messagingengine.com>
 <CANLSSBU55+tz6ujTJ7guGSwYNwsEZCXpf8WOgHXNRi420RGmXw@mail.gmail.com>
 <20130212045013.GF68798@USLT-205755.sungardas.corp>
 <CALFF=ZSZbNu8+rPFkugwy+Y2REyF+Dgxdzrt-yPE=vr1+PJ9gg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CALFF=ZSZbNu8+rPFkugwy+Y2REyF+Dgxdzrt-yPE=vr1+PJ9gg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

Some folks on this list have actually gone through the rigor of the
gerrit workflow on the OS lists [1] and can probably note the positive
and negative experiences. One thing I've seen is that almost all
reviews in OS come in with tests and without passing the devstack
tests (also integrated in gerrit) the patch isn't even picked up by
committers for code review.  

Personally I'm okay with either tool. IMO the real issue is in people
reviewing a patch within time for a release. On the review I've cited
we've got a lot of things to learn from -

a) timely response from blueprint (FS) owners and/or asking for time
for a thorough review
b) sign-off from multiple committers
c) incremental patch sets

Probably many more in just that example.

So if we think we can match up that kind of response time for patches
hitting a our gerrit setup then +1 for gerrit.

[1] https://review.openstack.org/#/c/3343/

-- 
Prasanna.,

On Wed, Feb 13, 2013 at 03:06:00PM -0500, Leif Gruenwoldt wrote:
> I recommend anyone for or against code review read this post by a
> Mozilla dev written on 18 Jan 2013.
> 
> "One of the discussions happening right now in the Mozilla Foundation
> software team is whether mandatory code reviews are a good thing.
> I?ve had versions of this conversation a number of times in the past
> few months, and today I?m going to write my thoughts down so I can
> point at them when it comes up in the future."
> 
> http://vocamus.net/dave/?p=1569