Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============4009904205532878596=="
MIME-Version: 1.0
Subject: Re: Review Request: CLOUDSTACK-356 Snapshot errors with multiple
 secondary
 storage in one zone.
From: "Min Chen" <min.chen@citrix.com>
To: "anthony xu" <anthony.xu@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Min Chen" <min.chen@citrix.com>, "deepti dohare" <deepti.dohare@citrix.com>
Date: Wed, 13 Feb 2013 21:56:41 -0000
Message-ID: <20130213215641.9635.28426@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Min Chen" <noreply@reviews.apache.org>
References: <20130108120942.2470.36383@reviews.apache.org>
In-Reply-To: <20130108120942.2470.36383@reviews.apache.org>
Reply-To: "Min Chen" <min.chen@citrix.com>

--===============4009904205532878596==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7594/#review16534
-----------------------------------------------------------


The fix for XenServer looks good. But I didn't see any change on other hype=
rvisor like Vmware and KVM. Since BackupSnapshotCommand is also used in oth=
er hypervisor, what behavior will we see there?

- Min Chen


On Jan. 8, 2013, 12:09 p.m., deepti dohare wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7594/
> -----------------------------------------------------------
> =

> (Updated Jan. 8, 2013, 12:09 p.m.)
> =

> =

> Review request for cloudstack and anthony xu.
> =

> =

> Description
> -------
> =

> Fixed CLOUDSTACK-356
> The issue is happening because of the multiple secondary storages, the se=
condary storage which is used first is getting mounted on the host resultin=
g in failure of other snapshot using different secondary storage as it is n=
ot getting mounted on the host. =

> For eg:
> 1. When first incremental snapshot (eg Ssec1-1) is taken, secondary stora=
ge (sec1) is mounted on local path =E2=80=9C/var/run/sr-mount/ on the host. =

> 2. Second incremental snapshot (Ssec1-2) is created, to get the parent vh=
d, the secondary storage is mounted at mount path =E2=80=9C/var/run/cloud_m=
ount/dc_id/snapshots=E2=80=9D.
> 3. If other snapshot (for different volume) is created on different secon=
dary storage (sec2), sec2 is not getting mounted on "/var/run/cloud_mount/d=
c_id/snapshots" path.                              =

> =

> The fix is to mount other secondary storages as well on the host. The loc=
al mount path in vmopsSnapshot.py is modified, instead of mounting on =E2=
=80=9C/var/run/cloud_mount/dc_id/snapshots=E2=80=9D, =E2=80=9C/var/run/clou=
d_mount/dc_id/snapshots/secHostid=E2=80=9D mount path is used.
> =

> =

> This addresses bug CLOUDSTACK-356.
> =

> =

> Diffs
> -----
> =

>   api/src/com/cloud/agent/api/BackupSnapshotCommand.java 7ea7835 =

>   api/test/src/com/cloud/agent/api/test/BackupSnapshotAnswerTest.java b3f=
2847 =

>   api/test/src/com/cloud/agent/api/test/BackupSnapshotCommandTest.java a6=
24148 =

>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixRes=
ourceBase.java 36a12b1 =

>   scripts/vm/hypervisor/xenserver/vmopsSnapshot 80e21f8 =

>   scripts/vm/hypervisor/xenserver/xcposs/vmopsSnapshot f7b2e0e =

>   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 7ab464b =

> =

> Diff: https://reviews.apache.org/r/7594/diff/
> =

> =

> Testing
> -------
> =

> Tested for following cases:
> 1. Snapshot Creation: =

> Host 1 has a vm i-1, volume ROOT-1 DATA-1, Host 2 has a vm i-2, volume RO=
OT-2 DATA-2, Taken recurring snapshot for 4 volumes.
> Verified: multiple secondary storages are getting mounted on host. Snapsh=
ots creation successful
> 2. Template Creation: =

> Verified: templates successfully created from the above snapshots
> 3. Volume creation:
> Verified: volumes successfully created from the above snapshots
> 4. VM Migration
> Migrate i-1  from Host-1 to Host-2. =

> Verified: Secondary mount point successfully created on Host-2.  =

>  =

> =

> =

> Thanks,
> =

> deepti dohare
> =

>


--===============4009904205532878596==--