Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 073DDE2C0 for ; Mon, 11 Feb 2013 19:58:10 +0000 (UTC) Received: (qmail 88558 invoked by uid 500); 11 Feb 2013 19:58:09 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 88524 invoked by uid 500); 11 Feb 2013 19:58:09 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 88512 invoked by uid 99); 11 Feb 2013 19:58:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2013 19:58:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 229721C737C; Mon, 11 Feb 2013 19:58:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7363156106281998924==" MIME-Version: 1.0 Subject: Re: Review Request: [EC2 Query API] Permission denied exception when a parameter value contains space From: "Prachi Damle" To: "Prachi Damle" Cc: "cloudstack" , "Likitha Shetty" Date: Mon, 11 Feb 2013 19:58:02 -0000 Message-ID: <20130211195802.21521.84831@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prachi Damle" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9230/ X-Sender: "Prachi Damle" References: <20130201061030.24984.65409@reviews.apache.org> In-Reply-To: <20130201061030.24984.65409@reviews.apache.org> Reply-To: "Prachi Damle" --===============7363156106281998924== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9230/#review16440 ----------------------------------------------------------- Likitha, There seems to be a typo trying to replace ~ by %7E. YOu seem to be doing t= he other way instead. The changes done seem to encode following 3 characters in the input URL: sp= ace, * and ~: Please can you update if you tested all 3 inputs? - Prachi Damle On Feb. 1, 2013, 6:10 a.m., Likitha Shetty wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9230/ > ----------------------------------------------------------- > = > (Updated Feb. 1, 2013, 6:10 a.m.) > = > = > Review request for cloudstack and Prachi Damle. > = > = > Description > ------- > = > Convert space characters in the parameters to %20 while forming a query s= tring after url-encode because java.net.URLEncoder performs application/x-w= ww-form-urlencoded-type encoding and not percent-encoding. According to RFC= 3986 as required by Amazon, we need to percent-encode. > = > = > This addresses bug CLOUDSTACK-1125. > = > = > Diffs > ----- > = > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f = > = > Diff: https://reviews.apache.org/r/9230/diff/ > = > = > Testing > ------- > = > Make any EC2 Query API call with a space in the parameter value - the api= call should be successfully executed and throw an error = > = > = > Thanks, > = > Likitha Shetty > = > --===============7363156106281998924==--