Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Content-Type: multipart/alternative;
 boundary="===============3247883040930969915=="
MIME-Version: 1.0
Subject: Re: Review Request: Decoupling Account and User mgmt by introducing
 UserService and UserManager
From: "Chip Childers" <chip.childers@sungard.com>
To: "Alex Huang" <alex.huang@citrix.com>
Cc: "Chip Childers" <chip.childers@sungard.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Manikanta Kattamuri" <mani.kattamuri@sungard.com>
Date: Fri, 08 Feb 2013 16:14:38 -0000
Message-ID: <20130208161438.13217.64846@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Chip Childers" <noreply@reviews.apache.org>
References: <20130208074850.13218.43434@reviews.apache.org>
In-Reply-To: <20130208074850.13218.43434@reviews.apache.org>
Reply-To: "Chip Childers" <chip.childers@sungard.com>

--===============3247883040930969915==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9361/#review16354
-----------------------------------------------------------


Mani - This is an opportunity to write some tests that ensure that the refa=
ctoring doesn't break anything.  Thank you for testing from the UI, but I'd=
 like to see some unit tests added that covers the restructured classes.  I=
 think it would also be good to run any appropriate Marvin tests against th=
is code (you may have to ask on the dev list for help on that one) to ensur=
e that the external API remains intact.

- Chip Childers


On Feb. 8, 2013, 7:48 a.m., Manikanta Kattamuri wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9361/
> -----------------------------------------------------------
> =

> (Updated Feb. 8, 2013, 7:48 a.m.)
> =

> =

> Review request for cloudstack and Alex Huang.
> =

> =

> Description
> -------
> =

> Decoupling Account and User mgmt by introducing UserService and UserManag=
er
> Added and moved user related services to UserService& UserManager from Ac=
countServices and AccountManager.
> Updated the referances of user related call from accountmgr to usermgr
> =

> =

> Diffs
> -----
> =

>   api/src/com/cloud/user/AccountService.java 8026891 =

>   api/src/com/cloud/user/UserService.java PRE-CREATION =

>   api/src/org/apache/cloudstack/api/BaseCmd.java a9ac489 =

>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java=
 d1f72c4 =

>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java d=
be3303 =

>   server/src/com/cloud/api/ApiServer.java e41fcb5 =

>   server/src/com/cloud/user/AccountManager.java 4b3a601 =

>   server/src/com/cloud/user/AccountManagerImpl.java 54447a2 =

>   server/src/com/cloud/user/UserManager.java PRE-CREATION =

>   server/src/com/cloud/user/UserManagerImpl.java PRE-CREATION =

>   server/src/org/apache/cloudstack/region/RegionManagerImpl.java c7bca5b =

>   server/src/org/apache/cloudstack/region/RegionServiceImpl.java 7aed881 =

>   server/test/com/cloud/user/MockAccountManagerImpl.java 5632070 =

>   server/test/com/cloud/user/MockUserManagerImpl.java PRE-CREATION =

> =

> Diff: https://reviews.apache.org/r/9361/diff/
> =

> =

> Testing
> -------
> =

> Performed testing on the affected api's from UI.
> =

> =

> Thanks,
> =

> Manikanta Kattamuri
> =

>


--===============3247883040930969915==--