Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AF010E479 for ; Wed, 6 Feb 2013 09:03:03 +0000 (UTC) Received: (qmail 23555 invoked by uid 500); 6 Feb 2013 09:03:03 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 23520 invoked by uid 500); 6 Feb 2013 09:03:03 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 23476 invoked by uid 99); 6 Feb 2013 09:03:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Feb 2013 09:03:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F05AC1C6807; Wed, 6 Feb 2013 09:02:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4544032251135213305==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support From: "Hongtu Zang" To: "Marcus Sorensen" , "mice xia" Cc: "Sateesh Chodapuneedi" , "cloudstack" , "Hongtu Zang" Date: Wed, 06 Feb 2013 09:02:54 -0000 Message-ID: <20130206090254.13217.7623@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Hongtu Zang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9241/ X-Sender: "Hongtu Zang" References: <20130206015706.13217.84689@reviews.apache.org> In-Reply-To: <20130206015706.13217.84689@reviews.apache.org> Reply-To: "Hongtu Zang" --===============4544032251135213305== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9241/ ----------------------------------------------------------- (Updated Feb. 6, 2013, 9:02 a.m.) Review request for cloudstack, mice xia and Marcus Sorensen. Changes ------- rebased and you can apply it cleanly. Description ------- add vmware resizeVolume support This addresses bug CLOUDSTACK-644. Diffs (updated) ----- plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/Vmwar= eResource.java a1b1336 = server/src/com/cloud/storage/StorageManagerImpl.java 45e3a7f = Diff: https://reviews.apache.org/r/9241/diff/ Testing ------- Start a vm using builtin template [CentOS 5.3(64-bit) no GUI (vSphere)]. Attach two data volumes, one made by disk_offering "Small", another made by= "Custom". Try to resize the two volumes when vm in running or stopped state. After the api finished resize the volume, we found the size changed in the = vSphere Client while the size in system is not changed. Reboot the vm and u= se fdisk to check the disk size, we found the size is changed. If we try to shrink the volume, the vsphere will throw an exception, I add = a check in the code before resize volume. If the newSize is smaller, it wil= l return false. Thanks, Hongtu Zang --===============4544032251135213305==--