Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============6062766504890023840=="
MIME-Version: 1.0
Subject: Re: Review Request: Provide customizable instance names for guest VMs
 in
 cloudstack
From: "Wei ZHOU" <w.zhou@leaseweb.com>
To: "Frank Zhang" <frank.zhang@citrix.com>,
 "Kelven Yang" <kelven.yang@citrix.com>
Cc: "Wei ZHOU" <w.zhou@leaseweb.com>, "Koushik Das" <koushik.das@citrix.com>,
 "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidipati@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>
Date: Tue, 05 Feb 2013 12:48:52 -0000
Message-ID: <20130205124852.13218.45005@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Wei ZHOU" <noreply@reviews.apache.org>
References: <20130201095016.21270.60348@reviews.apache.org>
In-Reply-To: <20130201095016.21270.60348@reviews.apache.org>
Reply-To: "Wei ZHOU" <w.zhou@leaseweb.com>

--===============6062766504890023840==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On Feb. 1, 2013, 9:50 a.m., Koushik Das wrote:
> > There is another config parameter instance.name based on which a fixed =
suffix is appended to the internal name. What happens to this parameter in =
the context of this fix? Also as part of this fix you are allowing to suffi=
x the display name to internal name. Sometime back I saw a request in the c=
s-user list to allow account name/id to be appended to the internal instanc=
e name. Would it be possible to provide a list of well defined attributes (=
for e.g. display name, account etc.) + fixed suffix.
> =

> Wei ZHOU wrote:
>     Is it neccessary to add i-<>-<> as a suffix to displayname or interna=
l name?
>     =

>     As a user, I totally agree with the requirements which were posted on=
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+user+provided=
+hostname%2C+internal+VM+name+on+hypervisor+for+guest+VMs
>     It seems that the result of this patch does not match the requirement=
s.
>     =

>     In setup/db/db/schema-40to410.sql, the field should be 'vm.instancena=
me.flag', not 'vm.hostname.flag'.

Does this patch apply on master? =

I fail to apply on master, and change source codes manually. =

I have the same testing result which is fine.

a suggestion:
can you change createDhcpEntryCommand(VirtualRouter, UserVm, NicVO, Command=
s) in com.cloud.network.router.VirtualNetworkApplianceManagerImpl, so that =
the OS hostname of VM can be set to displayname?


- Wei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9202/#review16001
-----------------------------------------------------------


On Jan. 31, 2013, 7:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9202/
> -----------------------------------------------------------
> =

> (Updated Jan. 31, 2013, 7:21 p.m.)
> =

> =

> Review request for cloudstack, Kelven Yang and Frank Zhang.
> =

> =

> Description
> -------
> =

> Patch to allow user to append display name to internal instance name of g=
uest VMs on cloudstack during guest VM creation.
> =

> =

> This addresses bug CS-778.
> =

> =

> Diffs
> -----
> =

>   server/src/com/cloud/configuration/Config.java 4ae144e =

>   server/src/com/cloud/vm/UserVmManagerImpl.java ecf1242 =

>   server/src/com/cloud/vm/dao/VMInstanceDao.java 8b0a523 =

>   server/src/com/cloud/vm/dao/VMInstanceDaoImpl.java 85ad5d0 =

>   setup/db/db/schema-40to410.sql ed4946e =

> =

> Diff: https://reviews.apache.org/r/9202/diff/
> =

> =

> Testing
> -------
> =

> Manual Testing:
> Set the global parameter vm.instancename.flag to true, restart mgmt serve=
r, create a guest VM and provide a display Name value when doing so. The vm=
 created will have its internal name in the form of i-<>-<>-displayname.
> Set the global parameter vm.instancename.flag back to false, restart mgmt=
 server, and create a guest VM providing the display Name. The vm created w=
ill have the internal name in the form of i-<>-<>
> If no display name is provided during instance creation, the vm internal =
name will be in the form of i-<>-<>.
> =

> =

> Thanks,
> =

> Venkata Siva Vijayendra Bhamidipati
> =

>


--===============6062766504890023840==--