Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D1896E381 for ; Tue, 5 Feb 2013 11:14:15 +0000 (UTC) Received: (qmail 74642 invoked by uid 500); 5 Feb 2013 11:14:15 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 74605 invoked by uid 500); 5 Feb 2013 11:14:15 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 74572 invoked by uid 99); 5 Feb 2013 11:14:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Feb 2013 11:14:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7B9011C6A03; Tue, 5 Feb 2013 11:14:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4545906181605845503==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-446: Host going to alert state, if you are adding already added host From: "Abhinandan Prateek" To: "Abhinandan Prateek" , "Alex Huang" Cc: "cloudstack" , "Koushik Das" Date: Tue, 05 Feb 2013 11:14:07 -0000 Message-ID: <20130205111407.13216.32268@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Abhinandan Prateek" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7891/ X-Sender: "Abhinandan Prateek" References: <20130205104609.13216.49637@reviews.apache.org> In-Reply-To: <20130205104609.13216.49637@reviews.apache.org> Reply-To: "Abhinandan Prateek" --===============4545906181605845503== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7891/#review16106 ----------------------------------------------------------- Ship it! Ship It! - Abhinandan Prateek On Feb. 5, 2013, 10:46 a.m., Koushik Das wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7891/ > ----------------------------------------------------------- > = > (Updated Feb. 5, 2013, 10:46 a.m.) > = > = > Review request for cloudstack, Abhinandan Prateek and Alex Huang. > = > = > Description > ------- > = > Adding an already added host fails with error but in the process incorrec= tly updates the status of the host to 'Alert'. Have put a check to prevent = this. > = > = > Diffs > ----- > = > server/src/com/cloud/resource/ResourceManagerImpl.java f4fa13b = > = > Diff: https://reviews.apache.org/r/7891/diff/ > = > = > Testing > ------- > = > Steps to repro > 1. Created a vmware cluster and added a host, verify that the status show= s as 'Up' > 2. Added the same host again, fails with error > 3. Refresh the host page in MS UI to verify that host status chages to 'A= lert' from 'Up' > = > After applying the fix follow the same repro steps and verify that the ho= st status doesn't change to 'Alert'. > = > = > Thanks, > = > Koushik Das > = > --===============4545906181605845503==--