Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CF238E0AA for ; Fri, 1 Feb 2013 12:51:20 +0000 (UTC) Received: (qmail 31510 invoked by uid 500); 1 Feb 2013 12:40:01 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 31329 invoked by uid 500); 1 Feb 2013 12:39:58 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 30885 invoked by uid 99); 1 Feb 2013 12:39:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2013 12:39:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C59C71C6F41; Fri, 1 Feb 2013 12:39:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1719607501247484614==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-435: Vmware network labels are ignored when creating a Zone using basic networking From: "Koushik Das" To: "Murali Reddy" , "Kelven Yang" Cc: "cloudstack" , "Koushik Das" Date: Fri, 01 Feb 2013 12:39:41 -0000 Message-ID: <20130201123941.21270.51798@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Koushik Das" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7827/ X-Sender: "Koushik Das" References: <20121101182259.9681.14135@reviews.apache.org> In-Reply-To: <20121101182259.9681.14135@reviews.apache.org> Reply-To: "Koushik Das" --===============1719607501247484614== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7827/#review16006 ----------------------------------------------------------- This review is sitting idle for the past 3 months. If there are no objectio= ns I am going to add this to master. - Koushik Das On Nov. 1, 2012, 6:22 p.m., Koushik Das wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7827/ > ----------------------------------------------------------- > = > (Updated Nov. 1, 2012, 6:22 p.m.) > = > = > Review request for cloudstack, Murali Reddy and Kelven Yang. > = > = > Description > ------- > = > Due to incorrect logic the private network traffic label specified was no= t getting used, instead some default was getting used (vSwitch0 or privateE= thernetPortProfile). The fix passes the correct label in the format vSwitch= X or vSwitchX, and based on that the correct switch is used. > = > = > Diffs > ----- > = > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmwa= reManagerImpl.java 64ded51 = > = > Diff: https://reviews.apache.org/r/7827/diff/ > = > = > Testing > ------- > = > Verified that the traffic labels are getting used and correct vSwitch is = getting used for the different traffic types. > = > = > Thanks, > = > Koushik Das > = > --===============1719607501247484614==--