Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============8468325892919889059=="
MIME-Version: 1.0
Subject: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
 CloudStack'.
From: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>
To: "Murali Reddy" <muralimmreddy@gmail.com>,
 "Kelven Yang" <kelven.yang@citrix.com>
Cc: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>
Date: Fri, 01 Feb 2013 01:46:51 -0000
Message-ID: <20130201014651.24967.92251@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sateesh Chodapuneedi" <noreply@reviews.apache.org>
Reply-To: "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>

--===============8468325892919889059==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/
-----------------------------------------------------------

Review request for cloudstack, Murali Reddy and Kelven Yang.


Description
-------

This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStac=
k'.
Virtual switch type could be chosen at zone level or at cluster level for s=
pecific traffic type.
UI functionality is also included.
autoExpand of dvPortGroup is available in code but disabled as its breaking=
 because vCenter 4.1 does not support autoExpand feature.


This addresses bug CLOUDSTACK-657.


Diffs
-----

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDi=
scoverer.java 684df54 =

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmware=
Manager.java be3fe9f =

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmware=
ManagerImpl.java c450312 =

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/Vmwar=
eResource.java 96c4348 =

  server/src/com/cloud/resource/ResourceManagerImpl.java f82424a =

  ui/scripts/system.js 2ce7672 =

  ui/scripts/zoneWizard.js 26838a1 =

  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java =
50f9541 =


Diff: https://reviews.apache.org/r/9210/diff/


Testing
-------

Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In t=
his case management and public traffic uses standard vSwitch on a common ph=
ysical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical=
 network.
3) Use optional parameters added to AddClusterCmd to override Zone level ne=
twork traffic label. Tested 2 clusters, one with standard vSwitch and other=
 with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parame=
ter 'vmware.use.dvswitch' set to false. This is default configuration scena=
rio.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi


--===============8468325892919889059==--