cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-1168) Create firewall rule broken
Date Wed, 06 Feb 2013 23:30:12 GMT


ASF subversion and git services commented on CLOUDSTACK-1168:

Commit ec6fdc7471a327a30c16426012a6132fab4e40a2 in branch refs/heads/vim51_win8 from [~mlsorensen]
[;h=ec6fdc7 ]

Summary: Fix NPE when calling createFirewallRule

Detail: was returning 'null' for getTrafficType().
Recently, getTrafficType started being used by createIngressFirewallRule.
Changing getTrafficType() to return ingress per Jayapal Reddy.

Bugfix-for: master,4.1
Signed-off-by: Marcus Sorensen <> 1360170916 -0700

> Create firewall rule broken
> ---------------------------
>                 Key: CLOUDSTACK-1168
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Network Controller
>    Affects Versions: 4.1.0
>         Environment: devcloud
>            Reporter: Marcus Sorensen
>            Assignee: Jayapal Reddy
>             Fix For: 4.1.0
> Following code, get null pointer in server/src/com/cloud/network/firewall/
at 484 due to object 'trafficType'.
> Follow this up to createFirewallRule, then to createIngressFirewallRule, where we see
rule.getTrafficType() then to file
>     public TrafficType getTrafficType() {
>         return null;
>     }
> I think we should modify createIngressFirewallRule and createEgressFirewallRule to pass
FirewallRule.TrafficType.Ingress and FirewallRule.TrafficType.Egress, but does anyone who
is responsible for this code want to take a look? Maybe we need to look at other places that
might be affected?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message