cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Nalley <>
Subject Re: [DISCUSS] Code Reviewing process (was Re: Build failed in Jenkins: cloudstack-rat-41 #58)
Date Fri, 22 Feb 2013 18:26:58 GMT
On Fri, Feb 22, 2013 at 12:18 PM, Chip Childers
<> wrote:
> On Fri, Feb 22, 2013 at 04:26:43PM +0530, Rohit Yadav wrote:
>> Hugo, I just want some better engineering process than the current
>> one. Yes, we can disagree and have different views on the same thing.
>> Nonetheless, I just want us to find a better solution, workflow than
>> the current one, just want to help.
> I think we all do. ;-)
> I made this point in another related thread, in that I think that we can
> look at the behavioural fixes separately from a tooling fix.  Let's
> agree on the "checklist" of things to look at prior to a merge and / or
> a patch commit.  If we agree there, we start holding ourselves to that
> (and revert or fix when we make a mistake).
> Tooling can compliment this, but will be a longer lead time to
> implement and agree on.

Yes, this is a cultural problem, not a technology one.
We also need to ensure that the standards that are set are upheld,
both for the things that we are working on as well as the things
others are pushing in and hold each other accountable.

View raw message