cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.
Date Fri, 22 Feb 2013 06:42:16 GMT


> -----Original Message-----
> From: rohityadav89@gmail.com [mailto:rohityadav89@gmail.com] On Behalf
> Of Rohit Yadav
> Sent: Thursday, February 21, 2013 10:15 PM
> To: cloudstack-dev@incubator.apache.org; Kelven Yang
> Cc: Murali Reddy; Sateesh Chodapuneedi
> Subject: Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch
> in CloudStack'.
> 
> It's unclear when a committer gives a ship it on reviewboard, they should also
> include information on whether it is:
> 
> - Ship it, but needs one more review
> - Ship it, and it's already merged on respective branch
> - Ship it and is not merged.
> 
> Regards.
[Animesh>] Agreed I will put this in review board guidelines
> 
> On Fri, Feb 22, 2013 at 7:49 AM, Kelven Yang <kelven.yang@citrix.com> wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9196/#review16921
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Ship It!
> >
> > - Kelven Yang
> >
> >
> > On Feb. 6, 2013, 1:19 a.m., Sateesh Chodapuneedi wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/9196/
> >> -----------------------------------------------------------
> >>
> >> (Updated Feb. 6, 2013, 1:19 a.m.)
> >>
> >>
> >> Review request for cloudstack, Murali Reddy and Kelven Yang.
> >>
> >>
> >> Description
> >> -------
> >>
> >> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> >> This patch contains few helper functions (get dvswitch reference, check the
> type of a port group). Also added method getType() to VirtualSwitchType enum.
> >>
> >>
> >> This addresses bug CLOUDSTACK-657.
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java
> eb10e16
> >>   vmware-
> base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff
> >>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
> >> 47ff8e2
> >>
> >> Diff: https://reviews.apache.org/r/9196/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Manual testing:-
> >> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this
> case management and public traffic uses standard vSwitch on a common
> physical network.
> >> 2) Tested both guest traffic and public traffic over dvSwitch on a physical
> network.
> >> 3) Use optional parameters added to AddClusterCmd to override Zone level
> network traffic label. Tested 2 clusters, one with standard vSwitch and other
> with dvSwitch.
> >> 4) Tested all 3 traffic types on single physical network with global parameter
> 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> >>
> >>
> >> Added following tests,
> >> 1) Test fetching dvSwitch object from vCenter
> >> 2) Test for presence of dvPortGroup
> >> 3) Test presence of dvPortGroup
> >> 4) Test get existing dvPortGroup
> >> 5) fetch dvPortGroup configuration
> >> 6) Test compare dvPortGroup configuration
> >> 7) Test update dvPortGroup configuration
> >>
> >>
> >> Thanks,
> >>
> >> Sateesh Chodapuneedi
> >>
> >>
> >

Mime
View raw message