cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kishan Kavala <Kishan.Kav...@citrix.com>
Subject RE: VPC Functionality Not Pluggable
Date Mon, 04 Feb 2013 08:29:50 GMT
Yes, it needs fixing. I'm planning to make it pluggable as part of ExternalDevice support for
VPC.
https://issues.apache.org/jira/browse/CLOUDSTACK-749


> -----Original Message-----
> From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
> Sent: Monday, 4 February 2013 8:28 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: VPC Functionality Not Pluggable
> 
> Looks like a shortcut. Definitely needs fixing
> 
> On 1/31/13 6:34 PM, "Mills, Joseph" <joe@midokura.jp> wrote:
> 
> >I was looking through the code that handles creating VPCs and noticed
> >that it did not seem pluggable at the moment. For example, there are a
> >few places where the assumption is made that the only possible Vpc
> >element provider is VPCVirtualRouter:
> >
> >    protected VpcProvider getVpcElement() {
> >
> >
> >        if (vpcElement == null) {
> >
> >
> >            vpcElement =
> >((VpcProvider)_ntwkMgr.getElementImplementingProvider(Provider.VPCV
> irtu
> >alR
> >outer.getName()));
> >
> >
> >        }
> >
> >
> >
> >
> >
> >        if (vpcElement == null) {
> >
> >
> >            throw new CloudRuntimeException("Failed to initialize vpc
> >element");
> >
> >        }
> >
> >
> >
> >
> >
> >        return vpcElement;
> >
> >
> >    }
> >
> >Are there any plans to make the Vpc functionality in cloudstack pluggable?
> >Has anyone scoped out what the required changes would be?
> >
> >thanks,
> >Joe


Mime
View raw message