cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidip...@citrix.com>
Subject Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)
Date Fri, 22 Feb 2013 21:42:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/
-----------------------------------------------------------

(Updated Feb. 22, 2013, 9:42 p.m.)


Review request for cloudstack and Kelven Yang.


Changes
-------

Uploading single diff containing all changes.

PLEASE NOTE: The db changes were shifted from schema-40to410.sql to schema-410to420.sql but
that isn't working on the current master - the tables in schema-410to420.sql (user_vm_clone_setting
of this feature, data_store_provider and image_data_store) are not getting created in the
cloud db. Looking into it, will consult cloudstack-dev@i.a.o.


Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do
not include unit tests yet. The tests will be uploaded at the earliest.


This addresses bug CS-670.


Diffs (updated)
-----

  core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
6b6bf19 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
f754c58 
  server/conf/migration-components.xml 90fbafa 
  server/src/com/cloud/configuration/Config.java 8c77715 
  server/src/com/cloud/vm/UserVmManagerImpl.java cf9eb27 
  server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION 
  server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION 
  server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION 
  server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION 
  server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 
  setup/db/db/schema-410to420.sql 4637b6d 

Diff: https://reviews.apache.org/r/9439/diff/


Testing
-------

Manual Testing
==============

Creation of guest VMs when the global flag vmware.create.full.clone is set to its default
value of false will create those guest VMs as linked clones (current default behavior without
these changes).
Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create
those guest VMs as full clones.
Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to
reflect the clone type of the VMs.
Linked clones and full clones can reside together in the same cluster and work as expected.


Thanks,

Venkata Siva Vijayendra Bhamidipati


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message