cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <>
Subject Re: Review Request: IP Address Reservation within a Network
Date Tue, 19 Feb 2013 12:57:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 19, 2013, 12:57 p.m.)

Review request for cloudstack, Murali Reddy and Chiradeep Vittal.


Incorporated review comments.
Renamed guest_cidr to network_cidr.
Added intutive comments for the variables.
Patch applies cleanly on latest master.


    CLOUDSTACK-705 IP Address reservation for Isolated Guest Networks

CloudStack uses Guest CIDR for dhcp-range for the Guest VMs. The entire CIDR is used by CloudStack
for assigning IPs to Guest VMs.
IP Address Reservation will allow part of address space to be used for non CloudStack hosts/physical
servers also, by restricting the address space of CloudStack Guest VMs.
Reservation can be configured using update Network API by specifying guestvmCidr as an additional
Reservation will be applicable for Isolated Guest Networks including VPC.
reservediprange in the response will return the IP range that can be used for non Cloudstack

This addresses bug CLOUDSTACK-705.

Diffs (updated)

  api/src/com/cloud/network/ 2bf7b7f 
  api/src/com/cloud/network/ 37d46ac 
  api/src/com/cloud/network/ ace1bb6 
  api/src/com/cloud/network/vpc/ cc66b58 
  api/src/org/apache/cloudstack/api/ cd7d700 
  api/src/org/apache/cloudstack/api/command/user/network/ 6777407 
  api/src/org/apache/cloudstack/api/response/ 7b29efb 
  server/src/com/cloud/api/ a94e935 
  server/src/com/cloud/network/ 37b4903 
  server/src/com/cloud/network/dao/ d51a065 
  server/src/com/cloud/network/vpc/ fbb5788 
  server/src/com/cloud/upgrade/dao/ a43727c 
  server/test/com/cloud/network/ 4a24f9a 
  server/test/com/cloud/vpc/ bcaaa26 
  server/test/com/cloud/vpc/ 0a44a49 
  setup/db/db/schema-410to420.sql 65add75 



Tested manually the following scenarios:
Applying reservation when there are running VMs inside the guest_vm_cidr.
Applying reservation when there are running VMs outside the guest_vm_cidr.(not allowed)
Applying reservation when external device like Netscaler is configured in the guest_cidr.
Applying reservation in VPC tiers.
Applying reservation outside the range of guest_cidr.(not allowed)


Saksham Srivastava

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message