cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "deepti dohare" <>
Subject Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM
Date Mon, 18 Feb 2013 13:59:15 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 18, 2013, 1:59 p.m.)

Review request for cloudstack and Min Chen.


Updated the patch with the suggested changes.


Currently no warning or confirmation is given or required to delete an iso which is attached
to a virtual machine.

Fixing this issue using “force” delete option.
If an admin or a user deletes an ISO which is attached to a vm:
1. Without force option; gives a warning that ISO is attached to vm “Failed to delete iso.
It is currently attached to virtual machine. Please detach it before deleting”.
2. With force option: first detach the ISO from all vms and then deletes the ISO. 

This addresses bug CLOUDSTACK-357.

Diffs (updated)

  api/src/org/apache/cloudstack/api/command/user/iso/ c821775 
  server/src/com/cloud/template/ f9cf277 
  server/src/com/cloud/vm/dao/ 9fbcde3 
  server/src/com/cloud/vm/dao/ f2fc10b 
  ui/scripts/templates.js 040ce4a 



Verified locally. Tested for some cases:

1. Deleting iso(not attached to any vm)
2. Deleting iso(attached to multiple vms in same domain)
3. Deleting iso(attached to multiple vms in different domains)

For admin/user


deepti dohare

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message