cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata Siva Vijayendra Bhamidipati" <>
Subject Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)
Date Fri, 15 Feb 2013 10:56:27 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 15, 2013, 10:56 a.m.)

Review request for cloudstack and Kelven Yang.


For some reason, review board isn't accepting the 3rd diff containing the unit tests and the
enum changes. So, uploading the diff as a file. Please apply this diff on top of the first
two diffs.


Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do
not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.


  server/src/com/cloud/vm/ 19887ff 
  server/test/com/cloud/vm/dao/ PRE-CREATION 
  server/test/com/cloud/vm/dao/ PRE-CREATION 
  server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 



Manual Testing

Creation of guest VMs when the global flag vmware.create.full.clone is set to its default
value of false will create those guest VMs as linked clones (current default behavior without
these changes).
Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create
those guest VMs as full clones.
Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to
reflect the clone type of the VMs.
Linked clones and full clones can reside together in the same cluster and work as expected.


Venkata Siva Vijayendra Bhamidipati

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message