cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koushik Das" <koushik....@citrix.com>
Subject Re: Review Request: CLOUDSTACK-667: VM's base image updation facility
Date Fri, 15 Feb 2013 09:13:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9158/#review16638
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9158/#comment35312>

    In case of restoreVM can newTemplateId be null even if the user passes UUID for new template?
If possible do you want to continue with restoreVm with original template or fail the operation


- Koushik Das


On Feb. 7, 2013, 11:32 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9158/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 11:32 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-667: VM's base image updation facility
> disconnect the root disk >> destroy root disk >> create a new disk from new
template >> attach new disk as root disk to the vm 
> 
> 
> This addresses bug CLOUDSTACK-667.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java e98c2f2 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 390a2a2 
>   server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9158/diff/
> 
> 
> Testing
> -------
> 
> Did the manual testing locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message