cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Min Chen" <min.c...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-713 Limit Resources to domain/accounts
Date Tue, 12 Feb 2013 20:03:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9110/#review16478
-----------------------------------------------------------

Ship it!


- Min Chen


On Feb. 8, 2013, 11:25 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9110/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 11:25 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, Prasanna Santhanam, Chiradeep
Vittal, and Min Chen.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-713: Limit Resources to domain/accounts (CPU and Memory)
>     
>     Addition of two new resource types i.e. CPU and RAM in the existing pool of
>     resource types.
>     Added some methods to set the limits on these resources using updateResource
>     API command and to get a count using updateResourceCount. Also added calls in
>     Virtual machine life cycle to check these limits and to increment/decrement 
>     resource count
>     
>     Resource Name  :: Resource type number
>         CPU               8
>         Memory            9
> 
> 
> This addresses bug CLOUDSTACK-713.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/Resource.java 7f551d6 
>   api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java
91728ee 
>   api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java
33f2574 
>   api/src/org/apache/cloudstack/api/response/AccountResponse.java 0277d5b 
>   api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java 9d4f6c5 
>   api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java beead24 
>   server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java 22b807c 
>   server/src/com/cloud/api/query/vo/AccountJoinVO.java 6d37f4d 
>   server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 8e447bc 
>   server/src/com/cloud/configuration/Config.java cbd5b01 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 7419690 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 7dd726c 
>   server/test/com/cloud/resourcelimit/ResourceLimitManagerImplTest.java PRE-CREATION

>   server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java 690aed6 
>   setup/db/create-schema-view.sql f68a6ca 
>   setup/db/db/schema-40to410.sql d771a15 
> 
> Diff: https://reviews.apache.org/r/9110/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on my local CloudStack setup.
> Tested deployVirtualMachine API command with/without exceeded limits.
> Also tested APIs like: assignVirtualMachine, recoverVirtualMachine, destroyVirtualMachine
commands and checked the corresponding increment/decrement in the resource count in database.
> Added unit tests in the patch.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message