cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Zhou" <>
Subject Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database
Date Mon, 11 Feb 2013 10:10:19 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 11, 2013, 10:10 a.m.)

Review request for cloudstack, Prasanna Santhanam, Jessica Wang, and Chiradeep Vittal.


The patch applies on master.


The issue occur in two conditions
(1) If I use two sessions or browsers to EnableStaticNat on CloudStack UI. one is successful,
the other is failed. However, there is no ip in database.
(2) If I use API call EnableStaticNat several times The first time succeed, the second failed,
the third succeed. the result is success-fail-success-fail-success-fail, which it is not correct.

This is because the improperly use of result boolean flag in,
long, long, boolean), the table user_ip_address(one_to_one_nat , vm_id) will set to (0,null)
when the operation failed.

For this issue, I add a new flag "updated" to describe whether the table user_ip_address in
database has been changed..

This addresses bug CLOUDSTACK-1088.

Diffs (updated)

  server/src/com/cloud/network/rules/ 0a00d22 



Test in following operations
(1) assign a ip to a vm several times.
(2) assign two ip to a vm
(3) assign a ip to two vms
It works well.


Wei Zhou

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message