cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <saksham.srivast...@citrix.com>
Subject Re: Review Request: IP Address Reservation within a Network
Date Fri, 08 Feb 2013 09:39:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9180/
-----------------------------------------------------------

(Updated Feb. 8, 2013, 9:39 a.m.)


Review request for cloudstack, Murali Reddy and Chiradeep Vittal.


Changes
-------

Patch uploaded after Javelin and Ipv6 merges.
Removed merge conflicts.


Description
-------

    CLOUDSTACK-705 IP Address reservation for Isolated Guest Networks


CloudStack uses Guest CIDR for dhcp-range for the Guest VMs. The entire CIDR is used by CloudStack
for assigning IPs to Guest VMs.
IP Address Reservation will allow part of address space to be used for non CloudStack hosts/physical
servers also, by restricting the address space of CloudStack Guest VMs.
Reservation can be configured using update Network API by specifying guestvmCidr as an additional
parameter.
Reservation will be applicable for Isolated Guest Networks including VPC.
reservediprange in the response will return the IP range that can be used for non Cloudstack
hosts.


This addresses bug CLOUDSTACK-705.


Diffs (updated)
-----

  api/src/com/cloud/network/Network.java 2bf7b7f 
  api/src/com/cloud/network/NetworkProfile.java 37d46ac 
  api/src/com/cloud/network/NetworkService.java ace1bb6 
  api/src/com/cloud/network/vpc/VpcService.java cc66b58 
  api/src/org/apache/cloudstack/api/ApiConstants.java d29408e 
  api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java 6777407 
  api/src/org/apache/cloudstack/api/response/NetworkResponse.java 7b29efb 
  server/src/com/cloud/api/ApiResponseHelper.java 8c97615 
  server/src/com/cloud/network/NetworkServiceImpl.java d38d1f8 
  server/src/com/cloud/network/dao/NetworkVO.java d51a065 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 7197c36 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 4a24f9a 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java bcaaa26 
  server/test/com/cloud/vpc/MockVpcManagerImpl.java 0a44a49 
  setup/db/create-schema.sql f89c885 
  setup/db/db/schema-40to410.sql d771a15 

Diff: https://reviews.apache.org/r/9180/diff/


Testing
-------

Tested manually the following scenarios:
Applying reservation when there are running VMs inside the guest_vm_cidr.
Applying reservation when there are running VMs outside the guest_vm_cidr.(not allowed)
Applying reservation when external device like Netscaler is configured in the guest_cidr.
Applying reservation in VPC tiers.
Applying reservation outside the range of guest_cidr.(not allowed)


Thanks,

Saksham Srivastava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message