cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hongtu Zang" <hongtu_z...@tcloudcomputing.com>
Subject Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support
Date Wed, 06 Feb 2013 01:57:39 GMT


> On Feb. 5, 2013, 5:36 a.m., Marcus Sorensen wrote:
> > Thanks for the update. Two things:
> > 
> > 1) Did you decide what to do regarding the online resize? It sounded like maybe
that didn't work out. If that's the case, you can disable online resize by adding to StorageManagerImpl.java
at "/*Xen only works offline, SR does not support VDI.resizeOnline*/" to include check for
VMware as well. Or at the very least we need to update the functional spec stating that vmware
requires a reboot (or full power cycle?) for the guest to see the change so there is no confusion.
> > 
> > 2) It looks like this is the case from the code, but I'm wondering if you've tested
and verified that if you try to shrink with VMware that the async query result replies with
your "unable to resize volume from a larger size...", and actually I'd prefer that this say
something along the lines of "VMware doesn't support shrinking volume from size...", since
it indicates a permanent failure and why, rather than a generic failure.

1) I tried in windows 7 which has vmtools installed. After api returns success, refresh in
windows disk management, the disk size will be changed. I think the volume online resize relies
on vmtools and its operating system.
2) I tried to shrink the volume, it returns "Invalid Configuration for device 0", it is the
same with what shows on vSphere Client. The vSphere Client doesn't allowd to shrink volume
capacity also. I changed the error message to "VMware doesn't support shrinking volume from
size..."


- Hongtu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9241/#review16082
-----------------------------------------------------------


On Feb. 6, 2013, 1:57 a.m., Hongtu Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9241/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 1:57 a.m.)
> 
> 
> Review request for cloudstack, mice xia and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> add vmware resizeVolume support
> 
> 
> This addresses bug CLOUDSTACK-644.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
dd917f7 
>   server/src/com/cloud/storage/StorageManagerImpl.java 07f4d8a 
> 
> Diff: https://reviews.apache.org/r/9241/diff/
> 
> 
> Testing
> -------
> 
> Start a vm using builtin template [CentOS 5.3(64-bit) no GUI (vSphere)].
> Attach two data volumes, one made by disk_offering "Small", another made by "Custom".
> Try to resize the two volumes when vm in running or stopped state.
> After the api finished resize the volume, we found the size changed in the vSphere Client
while the size in system is not changed. Reboot the vm and use fdisk to check the disk size,
we found the size is changed.
> 
> If we try to shrink the volume, the vsphere will throw an exception, I add a check in
the code before resize volume. If the newSize is smaller, it will return false.
> 
> 
> Thanks,
> 
> Hongtu Zang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message