cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <>
Subject Review Request: fix createIngressFirewallRule and createEgressFirewallRule pass null as traffic type, leading to null pointer exception
Date Wed, 06 Feb 2013 00:32:36 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for cloudstack, Alena Prokharchyk and Jayapal Reddy.


createFirewallRuleCmd has a function getTrafficType(), which returns null.  the commands createIngressFirewallRule
and createEgressFirewallRule were recently added, and the traffic type is now passed via these
to validateFirewallRule. Since this is null, it returns a null pointer. This patch fixes this
particular scenario.

This addresses bug CLOUDSTACK-1168.


  server/src/com/cloud/network/firewall/ d3b4c0b 



Found it broken in devcloud, applied the patch, now firewall rule doesn't fail to create,
and rule seems to work in creating the rule on the router.


Marcus Sorensen

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message