cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Review Request: fix createIngressFirewallRule and createEgressFirewallRule pass null as traffic type, leading to null pointer exception
Date Wed, 06 Feb 2013 00:32:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9313/
-----------------------------------------------------------

Review request for cloudstack, Alena Prokharchyk and Jayapal Reddy.


Description
-------

createFirewallRuleCmd has a function getTrafficType(), which returns null.  the commands createIngressFirewallRule
and createEgressFirewallRule were recently added, and the traffic type is now passed via these
to validateFirewallRule. Since this is null, it returns a null pointer. This patch fixes this
particular scenario.


This addresses bug CLOUDSTACK-1168.


Diffs
-----

  server/src/com/cloud/network/firewall/FirewallManagerImpl.java d3b4c0b 

Diff: https://reviews.apache.org/r/9313/diff/


Testing
-------

Found it broken in devcloud, applied the patch, now firewall rule doesn't fail to create,
and rule seems to work in creating the rule on the router.


Thanks,

Marcus Sorensen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message