cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hongtu Zang" <hongtu_z...@tcloudcomputing.com>
Subject Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support
Date Sat, 02 Feb 2013 00:59:50 GMT


> On Feb. 1, 2013, 9:41 a.m., Sateesh Chodapuneedi wrote:
> >

Thanks for your advice. I did some changes.


> On Feb. 1, 2013, 9:41 a.m., Sateesh Chodapuneedi wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java,
line 517
> > <https://reviews.apache.org/r/9241/diff/1/?file=254592#file254592line517>
> >
> >     Better to do is null check for disk object

I checked the other code using the same function. They didn't check null also. It seems it
won't be null if vmMo.getDiskDevice(path, false) doesn't returned null.


- Hongtu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9241/#review15998
-----------------------------------------------------------


On Feb. 2, 2013, 12:59 a.m., Hongtu Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9241/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2013, 12:59 a.m.)
> 
> 
> Review request for cloudstack, mice xia and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> add vmware resizeVolume support
> 
> 
> This addresses bug CLOUDSTACK-644.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
dd917f7 
>   server/src/com/cloud/storage/StorageManagerImpl.java 07f4d8a 
> 
> Diff: https://reviews.apache.org/r/9241/diff/
> 
> 
> Testing
> -------
> 
> Start a vm using builtin template [CentOS 5.3(64-bit) no GUI (vSphere)].
> Attach two data volumes, one made by disk_offering "Small", another made by "Custom".
> Try to resize the two volumes when vm in running or stopped state.
> After the api finished resize the volume, we found the size changed in the vSphere Client
while the size in system is not changed. Reboot the vm and use fdisk to check the disk size,
we found the size is changed.
> 
> If we try to shrink the volume, the vsphere will throw an exception, I add a check in
the code before resize volume. If the newSize is smaller, it will return false.
> 
> 
> Thanks,
> 
> Hongtu Zang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message