cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Brockmeier <...@zonker.net>
Subject Re: Review Request: Fix for CloudStack-462. Installation Guide Errors Are Fixed
Date Fri, 22 Feb 2013 17:22:32 GMT
On Fri, Feb 22, 2013, at 11:05 AM, Radhika Puthiyetath wrote:
> What is the right process in such situation ? I have submitted the patch
> two months back. The patch was not reviewed for long. 

I think we're still figuring that out. Again, apologies that it's taken
this long - from the notes in the review, I was waiting on input from a
third party.
 
> Later some of the files are submitted to the Master, and now the patch is
> obsolete. Should I be resubmitting the patch rebasing the Master, or just
> abandon it ?

If it's not too much effort and there's still information in the patch
that hasn't made it in, please rebase against master. 

Sorry that it's been a pain! 


> -----Original Message-----
> From: Joe Brockmeier [mailto:noreply@reviews.apache.org] On Behalf Of Joe
> Brockmeier
> Sent: Friday, February 22, 2013 10:24 PM
> To: Chip Childers; Joe Brockmeier; David Nalley; Jessica Tomechak
> Cc: cloudstack; Radhika Puthiyetath
> Subject: Re: Review Request: Fix for CloudStack-462. Installation Guide
> Errors Are Fixed
> 
> 
> 
> > On Feb. 22, 2013, 3:35 p.m., Joe Brockmeier wrote:
> > > Hi Radhika,
> > > 
> > > Many apologies - but this patch does not apply cleanly now. Can you take another
crack at it and ping me when done? I'll make sure to look it over ASAP. Thanks!
> > > 
> > > Joe
> > 
> > Radhika PC wrote:
> >     Just saw Logan's comment that the files are already changed as the patch is
2 months old now; and  much recent files are on the Master.
> 
> Just clarifying - is the current documentation now accurate, or are you
> just noting that the files have changed? Thanks! If nothing else, I can
> probably pull any necessary changes in without having to rework the
> patches, if you want to abandon this patch set. Just let me know or feel
> free to ping me on IRC if you're about. (I'm in cloudstack-dev right
> now). 
> 
> Thanks!
> 
> Joe
> 
> 
> - Joe
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8636/#review16945
> -----------------------------------------------------------
> 
> 
> On Dec. 17, 2012, 2:03 p.m., Radhika PC wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8636/
> > -----------------------------------------------------------
> > 
> > (Updated Dec. 17, 2012, 2:03 p.m.)
> > 
> > 
> > Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, and
Joe Brockmeier.
> > 
> > 
> > Description
> > -------
> > 
> > 4.4.2 There is no .repo file at the link, so I created a simple one and chose to
ignore GPG checking. It is as follows: 
> > # cat /etc/yum.repos.d/cloudstack.repo [cloudstack] name=cloudstack 
> > baseurl=http://cloudstack.apt-get.eu/rhel/4.0/
> > enabled=1
> > gpgcheck=0
> > 
> > 4.5.3.1 Directory for vhd-util only exists after yum install 
> > cloud-client, and following yum-install cloud-client, is already 
> > present in /usr/lib64/cloud/common/scripts/vm/hypervisor/xenserver
> > 
> > 4.5.4.1 step 5, cloud-setup-databases complains about selinux, it 
> > needs to be put in permissive mode before this. I followed the steps 
> > intended for the hosts in section 8.1.6
> > 
> > Further, with the management server setup, before you can proceed to section 5 and
log in, you must run cloud-setup-management. 
> > 
> > 
> > This addresses bug CLOUDSTACK-462.
> > 
> > 
> > Diffs
> > -----
> > 
> >   docs/en-US/configure-package-repository.xml 9ef2307 
> >   docs/en-US/management-server-install-client.xml 7e81ec7 
> >   docs/en-US/management-server-install-db-local.xml 3e09c55
> > 
> > Diff: https://reviews.apache.org/r/8636/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > Doc builds. Patch applies without any error.
> > 
> > 
> > Thanks,
> > 
> > Radhika PC
> > 
> >
> 


Best,

jzb
-- 
Joe Brockmeier
jzb@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/

Mime
View raw message