Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D009D87B for ; Wed, 2 Jan 2013 03:23:37 +0000 (UTC) Received: (qmail 23997 invoked by uid 500); 2 Jan 2013 03:23:37 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 23629 invoked by uid 500); 2 Jan 2013 03:23:36 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 23583 invoked by uid 99); 2 Jan 2013 03:23:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jan 2013 03:23:35 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of isaacchiang@gmail.com designates 209.85.215.173 as permitted sender) Received: from [209.85.215.173] (HELO mail-ea0-f173.google.com) (209.85.215.173) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jan 2013 03:23:29 +0000 Received: by mail-ea0-f173.google.com with SMTP id i13so5495339eaa.4 for ; Tue, 01 Jan 2013 19:23:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1e6xfGoSYKwWu5U54oJjbLzNbXJ54VAAPlK6uh9EtCU=; b=FLur+w7vPc3bPZzwp3qZH5VuHLJL2xrgiWCqR1zpCXKzazNAOno2GqvPpPgwMUtTDl FXvpq0s/vY9AtrJukQJ+8UOG64Iuccu7ASXge3q3TE0vGkMDvYJrgvAMsl5RPRGNObHK KKoldibgbEalumUnElpVva9AwHsqOsgmJHoXb2tpGDBPDFzMqYHE5ZWYxzq8DvpCqZ/S 1ewXZAhEYKgDi8F6aZhg4zOe7UMzBatI3L1otgXlZB+dK+L92WeMQyGOmeN4/oLD8VZ0 i2jtdjrTZo515KYba7unVUPWCL1iuSCk4JvzUa/tsv3jaaDVKIXyBVJzoBgQo+ycddTI ydXw== MIME-Version: 1.0 Received: by 10.14.209.193 with SMTP id s41mr122184125eeo.9.1357096987367; Tue, 01 Jan 2013 19:23:07 -0800 (PST) Received: by 10.223.96.1 with HTTP; Tue, 1 Jan 2013 19:23:07 -0800 (PST) In-Reply-To: <20130102031715.29903.9321@reviews.apache.org> References: <20130102031715.29903.9321@reviews.apache.org> Date: Wed, 2 Jan 2013 11:23:07 +0800 Message-ID: Subject: Re: Review Request: CLOUDSTACK-437 : User and Domain admin can create his API key and secret key From: Isaac Chiang To: Gavin Lee Cc: cloudstack , Isaac Chiang Content-Type: multipart/alternative; boundary=e89a8f502b92db984304d245c37b X-Virus-Checked: Checked by ClamAV on apache.org --e89a8f502b92db984304d245c37b Content-Type: text/plain; charset=ISO-8859-1 Cannot find the reporter in the review request list, so redirect to Gavin who reviewed CloudStack-648. Thanks! On Wed, Jan 2, 2013 at 11:17 AM, Isaac Chiang wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8800/ > Review request for cloudstack and Gavin Lee. > By Isaac Chiang. > Description > > The patch is to fix the issue by using the same logic with issue : CLOUDSTACK-648. > > Testing > > 1. A CloudStack normal user can generate its own keys. > 2. A Domain admin can generate keys for domain users, including subdomain admins and subdomain users. > 3. Under the same domain, a domain admin cannot generate key for another domain admin. > > Diffs > > - client/tomcatconf/commands.properties.in (e55017c) > - ui/scripts/accounts.js (ba741a4) > > View Diff > --e89a8f502b92db984304d245c37b--