Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of rajesh.battala@citrix.com
 designates 203.166.19.134 as permitted sender)
From: Rajesh Battala <rajesh.battala@citrix.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>
Date: Tue, 29 Jan 2013 22:54:25 +0530
Subject: RE: Unit Tests for LoadBalancer functionality in ASF Master
Thread-Topic: Unit Tests for LoadBalancer functionality in ASF Master
Thread-Index: Ac3+QucItaChnACFTnmCzxw/ynh9QwAAoByg
Message-ID: 
 <97F4356AEA71904482CD192135C038F9011CC0D20E7C@BANPMAILBOX01.citrite.net>
References: 
 <97F4356AEA71904482CD192135C038F9011CC0D20E6F@BANPMAILBOX01.citrite.net>
 <CA+96GG43eYTAwERCM_GR_8ZyryuMwyk67ONqZrC3QFPAo9o6EA@mail.gmail.com>
In-Reply-To: 
 <CA+96GG43eYTAwERCM_GR_8ZyryuMwyk67ONqZrC3QFPAo9o6EA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0


> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Tuesday, January 29, 2013 10:35 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Unit Tests for LoadBalancer functionality in ASF Master
>=20
> On Tue, Jan 29, 2013 at 11:20 AM, Rajesh Battala <rajesh.battala@citrix.c=
om>
> wrote:
> > Hi All,
> >
> > I have almost done with my feature (AWS Style healthchecks for NetScale=
r).
> > I have got paused, how to write unit tests for healthchecks.
> >
> > Under cloud-server/test I didn't find any tests for LoadBalancer.  Ther=
e are not
> unit tests which tests the functionality of LB for VR, NetScaler, F5.
> > I didn't' find any guide/wiki how to write the tests for network servic=
es( Ex for
> LB\healthchecks).
> >
> > As there are only 2 days left for the feature code freeze, Writing a fr=
amework
> for entire LoadBalancer is not possible.
> >
> > It would be great if anyone writes unit tests for the network services,=
 so that
> later for any features/bug-fixes we can keep contributing to the unit tes=
ts.
> >
> > Can I go ahead and submit my feature for code-review and once basic uni=
t
> tests framework is available for networking I can add unittest for Health=
Check
> feature.
> >
> > This is holding me to submit my feature for the review. Please let me k=
now
> how to go about.
> >
> >
> > Thanks
> > Rajesh Battala
> >
>=20
> I think your concerns are valid.  Go ahead and submit for review.
> Perhaps you can spend a little time looking into how to best unit test
> LoadBalancer code while the feature is under review?
[]=20

Thanks a lot Chip. Will submit my feature for Review by tomorrow.=20

Thanks
Rajesh Battala