Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2CF62E129 for ; Thu, 31 Jan 2013 18:31:41 +0000 (UTC) Received: (qmail 81927 invoked by uid 500); 31 Jan 2013 18:31:40 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 81894 invoked by uid 500); 31 Jan 2013 18:31:40 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 81884 invoked by uid 99); 31 Jan 2013 18:31:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jan 2013 18:31:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EB93F1C63A6; Thu, 31 Jan 2013 18:31:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1543024418530181271==" MIME-Version: 1.0 Subject: Review Request: A minor refacotoring to the AccountManagerImpl.java to remove the superfluous interface implements From: "Joe San" To: "Joe San" , "cloudstack" Date: Thu, 31 Jan 2013 18:31:33 -0000 Message-ID: <20130131183133.24984.66275@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joe San" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9197/ X-Sender: "Joe San" Reply-To: "Joe San" --===============1543024418530181271== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9197/ ----------------------------------------------------------- Review request for cloudstack. Description ------- Removed AccountService from the implements clause as the AccountManager alr= eady implements the AccountService interface. So AccountManagerImpl does no= t need to implement the AccountService interface. This addresses bug CLOUDSTACK-1080. Diffs ----- server/src/com/cloud/user/AccountManagerImpl.java b910a03 = server/test/com/cloud/user/MockAccountManagerImpl.java 550304a = Diff: https://reviews.apache.org/r/9197/diff/ Testing ------- Thanks, Joe San --===============1543024418530181271==--