Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3010745311373855515=="
MIME-Version: 1.0
Subject: Review Request: IP Address Reservation within a Network
From: "saksham srivastava" <saksham.srivastava@citrix.com>
To: "saksham srivastava" <saksham.srivastava@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>
Date: Thu, 31 Jan 2013 15:57:04 -0000
Message-ID: <20130131155704.24967.16344@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "saksham srivastava" <noreply@reviews.apache.org>
Reply-To: "saksham srivastava" <saksham.srivastava@citrix.com>

--===============3010745311373855515==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9180/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

    CLOUDSTACK-705 IP Address reservation for Isolated Guest Networks


CloudStack uses Guest CIDR for dhcp-range for the Guest VMs. The entire CID=
R is used by CloudStack for assigning IPs to Guest VMs.
IP Address Reservation will allow part of address space to be used for non =
CloudStack hosts/physical servers also, by restricting the address space of=
 CloudStack Guest VMs.
Reservation can be configured using update Network API by specifying guestv=
mCidr as an additional parameter.
Reservation will be applicable for Isolated Guest Networks including VPC.
reservediprange in the response will return the IP range that can be used f=
or non Cloudstack hosts.


This addresses bug CLOUDSTACK-705.


Diffs
-----

  api/src/com/cloud/network/Network.java 413b6d9 =

  api/src/com/cloud/network/NetworkProfile.java bb59b04 =

  api/src/com/cloud/network/NetworkService.java 786afb1 =

  api/src/com/cloud/network/vpc/VpcService.java 68e062c =

  api/src/org/apache/cloudstack/api/ApiConstants.java d242830 =

  api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.j=
ava 978c71b =

  api/src/org/apache/cloudstack/api/response/NetworkResponse.java 64cc953 =

  server/src/com/cloud/api/ApiResponseHelper.java 641f25b =

  server/src/com/cloud/network/NetworkServiceImpl.java 7530e94 =

  server/src/com/cloud/network/NetworkVO.java 14b643b =

  server/src/com/cloud/network/guru/GuestNetworkGuru.java 9587885 =

  server/src/com/cloud/network/vpc/VpcManagerImpl.java fa6bd30 =

  server/test/com/cloud/network/MockNetworkManagerImpl.java e628033 =

  server/test/com/cloud/vpc/MockNetworkManagerImpl.java a0f9d00 =

  server/test/com/cloud/vpc/MockVpcManagerImpl.java 25799d1 =

  setup/db/create-schema.sql ead98a5 =

  setup/db/db/schema-40to410.sql ed4946e =


Diff: https://reviews.apache.org/r/9180/diff/


Testing
-------

Tested manually the following scenarios:
Applying reservation when there are running VMs inside the guest_vm_cidr.
Applying reservation when there are running VMs outside the guest_vm_cidr.(=
not allowed)
Applying reservation when external device like Netscaler is configured in t=
he guest_cidr.
Applying reservation in VPC tiers.
Applying reservation outside the range of guest_cidr.(not allowed)


Thanks,

saksham srivastava


--===============3010745311373855515==--