Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============8420209246895480206=="
MIME-Version: 1.0
Subject: Re: Review Request: CLOUDSTACK-803: HA gets triggered even when the
 host
 investigator is unable to determine the state of the host
From: "Abhinandan Prateek" <aprateek@apache.org>
To: "Abhinandan Prateek" <aprateek@apache.org>,
 "Alex Huang" <alex.huang@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Koushik Das" <koushik.das@citrix.com>
Date: Fri, 18 Jan 2013 11:47:43 -0000
Message-ID: <20130118114743.27590.82689@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Abhinandan Prateek" <noreply@reviews.apache.org>
References: <20130107082606.2471.27958@reviews.apache.org>
In-Reply-To: <20130107082606.2471.27958@reviews.apache.org>
Reply-To: "Abhinandan Prateek" <aprateek@apache.org>

--===============8420209246895480206==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8853/#review15486
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On Jan. 7, 2013, 8:26 a.m., Koushik Das wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8853/
> -----------------------------------------------------------
> =

> (Updated Jan. 7, 2013, 8:26 a.m.)
> =

> =

> Review request for cloudstack, Abhinandan Prateek and Alex Huang.
> =

> =

> Description
> -------
> =

> CS tries to do HA on VMs if it finds that the host on which they are runn=
ing is down. HA should only happen when CS is able to determine (host inves=
tigators return status as 'Down') that host is down. Currently due to a bug=
 in code even if the hosts investigators are unable to determine state (ret=
urns 'null'), HA gets triggered.
>  =

> This results in unnecessary HA of VMs.
> =

> The fix is to not do HA in case the state of host cannot be determined.
> =

> =

> This addresses bug CLOUDSTACK-803.
> =

> =

> Diffs
> -----
> =

>   server/src/com/cloud/agent/manager/AgentManagerImpl.java 8141fdb =

> =

> Diff: https://reviews.apache.org/r/8853/diff/
> =

> =

> Testing
> -------
> =

> I did the following manual testing
> =

> -	Setup advanced zone with XS host
> -	Created a VM
> -	Pulled out network cable for MS
> -	Checked in the debugger that the DisconnectTask is running
> -	This calls  handleDisconnectWithInvestigation in AgentManagerImpl
> -	In the debugger saw that the following line of code is returning state =
as null 'final Status determinedState =3D investigate(attache);'
> -	So the warning message added is seen 's_logger.warn("Agent state cannot=
 be determined, do nothing");'
> -	The above steps continues in a loop till the time I plug the network ca=
ble back after which again the status of the host gets correctly determined=
 by the investigator.
> =

> If either the XS host or MS is disconnected from network then investigato=
r cannot determine the state of the host and so based on the fix HA won=E2=
=80=99t be triggered.
> =

> Sowmya from Citrix QA team also did additional testing for this on a priv=
ate branch.
> =

> =

> Thanks,
> =

> Koushik Das
> =

>


--===============8420209246895480206==--