Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B19E2E850 for ; Wed, 9 Jan 2013 05:27:43 +0000 (UTC) Received: (qmail 53610 invoked by uid 500); 9 Jan 2013 05:27:43 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 53479 invoked by uid 500); 9 Jan 2013 05:27:42 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 53452 invoked by uid 99); 9 Jan 2013 05:27:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2013 05:27:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4BBE41C5FD5; Wed, 9 Jan 2013 05:27:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6702346177435944632==" MIME-Version: 1.0 Subject: Re: Review Request: [API] ListTemplates API is not returning "Enable SSH Key" attribute for any given template From: "Min Chen" To: "Min Chen" , "Alena Prokharchyk" Cc: "cloudstack" , "Likitha Shetty" Date: Wed, 09 Jan 2013 05:27:36 -0000 Message-ID: <20130109052736.2470.69439@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Min Chen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8546/ X-Sender: "Min Chen" References: <20130109042206.2471.62630@reviews.apache.org> In-Reply-To: <20130109042206.2471.62630@reviews.apache.org> Reply-To: "Min Chen" --===============6702346177435944632== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8546/#review15176 ----------------------------------------------------------- This change looks good to me, however, due to recent api_refactoring merge = into master branch, I cannot apply this patch on master due to package name= change, here is the error: unknown14109fdb491b:cloud-asf minc$ git am < patchdir/0001-CLOUDSTACK-614-L= istTemplates-API-is-not-returning-En.patch Applying: CLOUDSTACK-614: ListTemplates API is not returning "Enable SSH Ke= y" attribute for any given template. error: api/src/com/cloud/api/response/TemplateResponse.java: does not exist= in index Patch failed at 0001 CLOUDSTACK-614: ListTemplates API is not returning "En= able SSH Key" attribute for any given template. Can you please create another patch based on latest master code and then I = can apply it for you? Thanks. - Min Chen On Jan. 9, 2013, 4:22 a.m., Likitha Shetty wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8546/ > ----------------------------------------------------------- > = > (Updated Jan. 9, 2013, 4:22 a.m.) > = > = > Review request for cloudstack, Alena Prokharchyk and Min Chen. > = > = > Description > ------- > = > Update the TemplateResponse by adding 'sshkeyenabled' attribute to it. Th= is attribute is set to the value that the user passes as input for paramete= r 'sshkeyenabled' while registering the template. > = > = > This addresses bug CLOUDSTACK-614. > = > = > Diffs > ----- > = > api/src/com/cloud/api/response/TemplateResponse.java 5c3d339 = > server/src/com/cloud/api/ApiResponseHelper.java ebe8415 = > = > Diff: https://reviews.apache.org/r/8546/diff/ > = > = > Testing > ------- > = > Called API command=3DlistTemplates&listall=3Dtrue&templatefilter=3Dfeatur= ed > The JSON response contained a boolean SSH related attribute called 'sshke= yenabled' which mentioned if the template is SSH enabled or not. > = > = > Thanks, > = > Likitha Shetty > = > --===============6702346177435944632==--