Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3431283562703819419=="
MIME-Version: 1.0
Subject: Review Request: CLOUDSTACK-803: HA gets triggered even when the host
 investigator is unable to determine the state of the host
From: "Koushik Das" <koushik.das@citrix.com>
To: "Alex Huang" <alex.huang@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Koushik Das" <koushik.das@citrix.com>
Date: Mon, 07 Jan 2013 05:47:40 -0000
Message-ID: <20130107054740.2470.18985@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Koushik Das" <noreply@reviews.apache.org>
Reply-To: "Koushik Das" <koushik.das@citrix.com>

--===============3431283562703819419==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8853/
-----------------------------------------------------------

Review request for cloudstack and Alex Huang.


Description
-------

CS tries to do HA on VMs if it finds that the host on which they are runnin=
g is down. HA should only happen when CS is able to determine (host investi=
gators return status as 'Down') that host is down. Currently due to a bug i=
n code even if the hosts investigators are unable to determine state (retur=
ns 'null'), HA gets triggered.
 =

This results in unnecessary HA of VMs.

The fix is to not do HA in case the state of host cannot be determined.


This addresses bug CLOUDSTACK-803.


Diffs
-----

  server/src/com/cloud/agent/manager/AgentManagerImpl.java 8141fdb =


Diff: https://reviews.apache.org/r/8853/diff/


Testing
-------

I did the following manual testing

-	Setup advanced zone with XS host
-	Created a VM
-	Pulled out network cable for MS
-	Checked in the debugger that the DisconnectTask is running
-	This calls  handleDisconnectWithInvestigation in AgentManagerImpl
-	In the debugger saw that the following line of code is returning state as=
 null 'final Status determinedState =3D investigate(attache);'
-	So the warning message added is seen 's_logger.warn("Agent state cannot b=
e determined, do nothing");'
-	The above steps continues in a loop till the time I plug the network cabl=
e back after which again the status of the host gets correctly determined b=
y the investigator.

If either the XS host or MS is disconnected from network then investigator =
cannot determine the state of the host and so based on the fix HA won=E2=80=
=99t be triggered.

Sowmya from Citrix QA team also did additional testing for this on a privat=
e branch.


Thanks,

Koushik Das


--===============3431283562703819419==--