From cloudstack-dev-return-18341-apmail-incubator-cloudstack-dev-archive=incubator.apache.org@incubator.apache.org Mon Jan 21 20:15:24 2013 Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B140DEC41 for ; Mon, 21 Jan 2013 20:15:24 +0000 (UTC) Received: (qmail 80014 invoked by uid 500); 21 Jan 2013 20:15:24 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 79981 invoked by uid 500); 21 Jan 2013 20:15:24 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 79969 invoked by uid 99); 21 Jan 2013 20:15:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jan 2013 20:15:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4C3B41C64FB; Mon, 21 Jan 2013 20:15:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7512347687346454450==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-672: Set VMware cluster max. limit based on HV version From: "David Nalley" To: "cloudstack" , "David Nalley" , "Koushik Das" Date: Mon, 21 Jan 2013 20:15:17 -0000 Message-ID: <20130121201517.9568.99902@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David Nalley" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9041/ X-Sender: "David Nalley" References: <20130121114458.9780.47209@reviews.apache.org> In-Reply-To: <20130121114458.9780.47209@reviews.apache.org> Reply-To: "David Nalley" --===============7512347687346454450== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9041/#review15550 ----------------------------------------------------------- setup/db/create-schema.sql You are setting the max_hosts_per_cluster for all VMware versions to 32= , yet I thought the proposal was only to affect 5.1 with the updated VMFS v= ersion. = setup/db/db/schema-40to410.sql You've altered the table and have now defined it as 32 in all versions = here as well. = - David Nalley On Jan. 21, 2013, 11:44 a.m., Koushik Das wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9041/ > ----------------------------------------------------------- > = > (Updated Jan. 21, 2013, 11:44 a.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > For Vmware max. hosts in a cluster is specific to HV version. This config= uration is read from the hypervisor_capabilities table. > Read the dev list discussion here: http://apache.markmail.org/thread/lva7= loblbksiavm7 > = > Scenarios: > - Adding a cluster to CS - From 1st host in the list of hosts discovered,= query the HV version. Based on the version read the max_hosts_per_cluster = limit from hypervisor_capabilities table and do the validation > - Adding a host to an existing cluster - Get the HV version from one of t= he hosts already present in cluster from CS db., then similar to previous s= cenario > = > The implementation is specific to Vmware only, haven't made the validatio= n logic generic as there are no limits for other HVs currently. > For upgraded scenarios, HV versions may not be present for the existing h= ost table entries. In that case the 'default' version will get used to read= the limit. > = > = > This addresses bug CLOUDSTACK-672. > = > = > Diffs > ----- > = > api/src/com/cloud/hypervisor/HypervisorCapabilities.java efb8a6a = > core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java 56e8e0a = > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServer= Discoverer.java 684df54 = > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmwa= reManager.java be3fe9f = > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/Vmwa= reManagerImpl.java c450312 = > server/src/com/cloud/configuration/Config.java 4ae144e = > server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDao.java 8f4a= 475 = > server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java = 1a6fb72 = > setup/db/create-schema.sql 174f53c = > setup/db/db/schema-40to410.sql a9d168d = > = > Diff: https://reviews.apache.org/r/9041/diff/ > = > = > Testing > ------- > = > Manually verifed the scenarios mentioned above. > = > = > Thanks, > = > Koushik Das > = > --===============7512347687346454450==--