cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CLOUDSTACK-1042) apidoc: copyIsoCmd has required arguments listed twice resulting in duplicate attributes in marvin
Date Wed, 23 Jan 2013 23:01:12 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rohit Yadav resolved CLOUDSTACK-1042.
-------------------------------------

    Resolution: Fixed

The issue was much bigger inside thanks for reporting! Helped me fix multiple issues in apidiscovery,
apidoc, generic dao base and apidispatcher :D

Fixed in commits on master;

commit 7a927e36f0824f0a74d6a57f68ff38bfc0dcade6
Author: Rohit Yadav <bhaisaab@apache.org>
Date:   Wed Jan 23 13:53:00 2013 -0800

    ReflectUtil: Use collections to grow list and not manual array memory management
    
    Fix usage in ApiDispatcher. Add two kinds of helpers:
    - One that gets list of exclude cmd whose fields are not be included
    - One that loops till a base class is asssignable from superclass
    
    Signed-off-by: Rohit Yadav <bhaisaab@apache.org>

commit a8623bacd73a1b1026df8770be1c6a98bde11ba6
Author: Rohit Yadav <bhaisaab@apache.org>
Date:   Wed Jan 23 13:50:59 2013 -0800

    ApiXmlDocWriter: Fix multiple field occurrence in apidocs by using set
    
    Signed-off-by: Rohit Yadav <bhaisaab@apache.org>

commit cbdeeebc6c1864e9ccdae55d0a125929e7be7b30
Author: Rohit Yadav <bhaisaab@apache.org>
Date:   Wed Jan 23 13:47:56 2013 -0800

    IteratorUtil: Add generic method to return sorted list out of a collection
    
    Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
                
> apidoc: copyIsoCmd has required arguments listed twice resulting in duplicate attributes
in marvin
> --------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-1042
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1042
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: Prasanna Santhanam
>            Assignee: Rohit Yadav
>
> on mvn -pl :cloud-apidoc I get the following copyIso.xml
> <command>
>   <command>
>     <name>copyIso</name>
>     <description>Copies an iso from one zone to another.</description>
>     <isAsync>true</isAsync>
>     <request>
>       <arg>
>         <name>id</name>
>         <description>Template ID.</description>
>         <required>true</required>
>       </arg>
>       <arg>
>         <name>destzoneid</name>
>         <description>ID of the zone the template is being copied to.</description>
>         <required>true</required>
>       </arg>
>       <arg>
>         <name>destzoneid</name>
>         <description>ID of the zone the template is being copied to.</description>
>         <required>true</required>
>       </arg>
>       <arg>
>         <name>sourcezoneid</name>
>         <description>ID of the zone the template is currently hosted on.</description>
>         <required>true</required>
>       </arg>
>       <arg>
>         <name>sourcezoneid</name>
>         <description>ID of the zone the template is currently hosted on.</description>
>         <required>true</required>
>       </arg>
>       <arg>
> Notice: sourcezoneid and destzoneid are repeated twice. This results the following marvin
entity:
>  5 class copyIsoCmd (baseCmd):
>   6     def __init__(self):
>   7         self.isAsync = "true"
>   8         """Template ID."""
>   9         """Required"""
>  10         self.id = None
>  11         """ID of the zone the template is being copied to."""
>  12         """Required"""
>  13         self.destzoneid = None
>  14         """ID of the zone the template is being copied to."""
>  15         """Required"""
>  16         self.destzoneid = None
>  17         """ID of the zone the template is currently hosted on."""
>  18         """Required"""
>  19         self.sourcezoneid = None
>  20         """ID of the zone the template is currently hosted on."""
>  21         """Required"""
>  22         self.sourcezoneid = None
> This is because CopyIso <- CopyTemplate <- BaseAsyncCmd and XmlDocWriter perhaps
need to check this exceptional case

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message