cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Mehta <Nitin.Me...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot
Date Wed, 09 Jan 2013 11:50:39 GMT
Exactly, so this is not a full fledged fix. Do you have a plan in mind to take care of volumes
already facing this issue ? Remember that the volumes created from ISO will also have template_id
as null so I understand that this is a bit tricky.

From: Saksham Srivastava <saksham.srivastava@citrix.com<mailto:saksham.srivastava@citrix.com>>
Reply-To: Saksham Srivastava <saksham.srivastava@citrix.com<mailto:saksham.srivastava@citrix.com>>
To: Devdeep Singh <devdeep.singh@citrix.com<mailto:devdeep.singh@citrix.com>>
Cc: Saksham Srivastava <saksham.srivastava@citrix.com<mailto:saksham.srivastava@citrix.com>>,
"cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>" <cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>>,
Nitin Mehta <nitin.mehta@citrix.com<mailto:nitin.mehta@citrix.com>>
Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template
is created from a snapshot

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/


On January 9th, 2013, 8:43 a.m., Nitin Mehta wrote:

You need to take care of migration as well. Any thoughts on that ?

The fix is only for the new volumes which are created from snapshots which were themselves
created from volumes which have a non-null template id.
In case of parent volume carrying a null template id, the subsequent volumes created from
it will be having null template id.





- saksham


On January 9th, 2013, 7:29 a.m., saksham srivastava wrote:

Review request for cloudstack and Devdeep Singh.
By saksham srivastava.

Updated Jan. 9, 2013, 7:29 a.m.

Description

Volumes created from snapshots misses the source template information.Fixed the issue with
volumes now getting the template id.


Testing

Verified on local setup. from template1->instance->snapshot1->volume1->snapshot2->template2
template2 now has source template id.


Bugs: CLOUDSTACK-924
Diffs

 *   server/src/com/cloud/storage/StorageManagerImpl.java (96f299c)

View Diff<https://reviews.apache.org/r/8900/diff/>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message