cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hari Kannan <hari.kan...@citrix.com>
Subject RE: Review Request: API commands to add or remove NIC from a VM
Date Mon, 21 Jan 2013 07:30:12 GMT
Can you please clarify a couple of points please - 

1. The FS states that " Currently in cloudstack there can be only on NIC on a network in cloudstack."
- this is not true right? We cannot add a network AFTER a VM is created, but you could have
multiple nics when the VM is first created?
2. Earlier, Marcus had stated that " It doesn't strictly require a reboot, but it does require
that you apply a network config. The nic will hot plug but you either have to reboot or manually
trigger a dhcp query " - wish to reconfirm this to be the case - also, can you please provide
a short note on how to do this, so we can add it to the documentation?
3. Can you please confirm this is possible for any OS (windows/Linux)?
4. is there any UI component developed for this?

Hari

-----Original Message-----
From: Marcus Sorensen [mailto:shadowsor@gmail.com] 
Sent: Friday, January 18, 2013 4:13 PM
To: Chiradeep Vittal
Cc: Brian Angus; cloudstack
Subject: Re: Review Request: API commands to add or remove NIC from a VM

Chiradeep, I sucked this into a development branch. I pulled master into that and he just
sent me a patch that fixes it.

On Fri, Jan 18, 2013 at 5:04 PM, Chiradeep Vittal <chiradeepv@gmail.com>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9011/
>
> Can you rebase against current master?
>
>
> - Chiradeep
>
> On January 17th, 2013, 7:38 p.m., Brian Angus wrote:
>   Review request for cloudstack and Marcus Sorensen.
> By Brian Angus.
>
> *Updated Jan. 17, 2013, 7:38 p.m.*
> Description
>
> This needs to be used to create a new feature branch.
>
> Feature Spec: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Add+Remove+Netw
> orks+to+VMs Jira Request: 
> https://issues.apache.org/jira/browse/CLOUDSTACK-645
>
> Added addNicToVirtualMachine, removeNicFromVirtualMachine, and updateDefaultNicForVirtualMachine
api commands.
>
>   Testing
>
> This was tested and works on devcloud and devcloud-kvm.  I plan to add some automated
tests as well.
>
>   *Bugs: * CLOUDSTACK-645
> Diffs
>
>    - api/src/com/cloud/vm/UserVmService.java (b1ebe10)
>    - api/src/org/apache/cloudstack/api/command/user/vm/AddNicToVMCmd.java
>    (PRE-CREATION)
>    - api/src/org/apache/cloudstack/api/command/user/vm/RemoveNicFromVMCmd.java
>    (PRE-CREATION)
>    - api/src/org/apache/cloudstack/api/command/user/vm/UpdateDefaultNicForVMCmd.java
>    (PRE-CREATION)
>    - client/tomcatconf/commands.properties.in (182cbd8)
>    - server/src/com/cloud/network/NetworkManagerImpl.java (0a1fcd7)
>    - server/src/com/cloud/vm/UserVmManagerImpl.java (a6fbdb1)
>    - server/src/com/cloud/vm/VirtualMachineManager.java (4f04617)
>    - server/src/com/cloud/vm/VirtualMachineManagerImpl.java (4d94fc5)
>    - server/test/com/cloud/vm/MockUserVmManagerImpl.java (27508b1)
>    - server/test/com/cloud/vm/MockVirtualMachineManagerImpl.java 
> (6723198)
>
> View Diff <https://reviews.apache.org/r/9011/diff/>
>

Mime
View raw message