cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rohit Yadav <rohit.ya...@citrix.com>
Subject Re: Review Request: remove redundant version info in two plugin pom.xml files
Date Tue, 08 Jan 2013 20:14:56 GMT
Yes, after ship it, the committer has to manually download the patch, commit, verify and push
it to the git repos.
On 08-Jan-2013, at 5:40 AM, Noa Resare <noa@spotify.com> wrote:

> Is the actual merging a manual process at this point? In such case,
> consider this email a gentle poke to the committers. If not, consider this
> a proto-bugreport :)
> 
> /n
> 
> 
> On Sun, Jan 6, 2013 at 12:22 AM, Rohit Yadav <bhaisaab@apache.org> wrote:
> 
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/8836/#review15094
>> -----------------------------------------------------------
>> 
>> Ship it!
>> 
>> 
>> Mentioning parent version is enough, it's good.
>> Thanks. Ship It!
>> 
>> - Rohit Yadav
>> 
>> 
>> On Jan. 4, 2013, 10:37 p.m., Noa Resare wrote:
>>> 
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/8836/
>>> -----------------------------------------------------------
>>> 
>>> (Updated Jan. 4, 2013, 10:37 p.m.)
>>> 
>>> 
>>> Review request for cloudstack.
>>> 
>>> 
>>> Description
>>> -------
>>> 
>>> I'm playing around with nonstandard artifact versions in maven, and
>> found two module pom files:
>>> 
>>> plugins/hypervisors/simulator/pom.xml
>>> plugins/network-elements/dns-notifier/pom.xml
>>> 
>>> that explicitly set's their versions. This is not needed, as they are
>> only used as submodules of the toplevel pom.xml and as such they inherit
>> the version of the toplevel project if the version element is absent.
>>> 
>>> The attached patch removes the redundant version information.
>>> 
>>> 
>>> This addresses bug CLOUDSTACK-790.
>>> 
>>> 
>>> Diffs
>>> -----
>>> 
>>>  plugins/hypervisors/simulator/pom.xml 15b3790
>>>  plugins/network-elements/dns-notifier/pom.xml 0b4c981
>>> 
>>> Diff: https://reviews.apache.org/r/8836/diff/
>>> 
>>> 
>>> Testing
>>> -------
>>> 
>>> 
>>> Thanks,
>>> 
>>> Noa Resare
>>> 
>>> 
>> 
>> 
> 
> 
> -- 
> Engineering Experience, Infrastructure tribe, Spotify


Mime
View raw message