cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot, CLOUDSTACK-667: VM's base image updation facility
Date Wed, 30 Jan 2013 11:37:57 GMT


> On Jan. 29, 2013, 5:34 p.m., Koushik Das wrote:
> > Hari,
> > The review request has changes for both CLOUDSTACK-745 & 667. Can you send out
separate review request for each? Also as a general rule a commit should correspond to a single
issue only.
> > 
> > -Koushik
> >

created two different review requests for two features.
CLOUDSTACK-745: Reset a VM on reboot - https://reviews.apache.org/r/9157/
CLOUDSTACK-667: VM's base image updation facility - https://reviews.apache.org/r/9158/
Uploaded the diff of CLOUDSTACK-745 as parent diff to CLOUDSTACK-667


Thanks


- Harikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9134/#review15801
-----------------------------------------------------------


On Jan. 29, 2013, 5:08 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9134/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 5:08 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-745: Reset a VM on reboot
> To have a method to reset the vm on its reboot.
> So on reboot, the vm's disk is discarded and creates a new root disk using the template.
> The use cases for this are
> -> Secure environments that need a fresh start on every boot
> -> Desktops that should not retain state 
> 
> CLOUDSTACK-667: VM's base image updation facility
> disconnect the root disk >> destroy root disk >> create a new disk from new
template >> attach new disk as root disk to the vm 
> 
> 
> This addresses bugs CLOUDSTACK-667 and CLOUDSTACK-745.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 48a0607 
>   api/src/com/cloud/offering/ServiceOffering.java b13346c 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831 
>   api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
54151fe 
>   api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java d906c7f 
>   core/src/com/cloud/vm/UserVmVO.java 05a4bd1 
>   core/src/com/cloud/vm/VMInstanceVO.java 13c1cf3 
>   server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 57cfb39 
>   server/src/com/cloud/configuration/ConfigurationManager.java 19e74bf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java df6642a 
>   server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e 
>   server/src/com/cloud/network/security/SecurityManagerMBeanImpl.java 9328190 
>   server/src/com/cloud/service/ServiceOfferingVO.java c199a86 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 5891056 
>   server/test/com/cloud/vm/dao/UserVmDaoImplTest.java f07abca 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3989ecf 
>   setup/db/create-schema.sql 174f53c 
>   setup/db/db/schema-40to410.sql 79b7f8f 
> 
> Diff: https://reviews.apache.org/r/9134/diff/
> 
> 
> Testing
> -------
> 
> Did the manual testing locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message