cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isaac Chiang" <isaacchi...@gmail.com>
Subject Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time
Date Thu, 24 Jan 2013 15:22:34 GMT


> On Jan. 24, 2013, 3 p.m., Pranav Saxena wrote:
> > Hey Isaac , 
> > Thanks  for the updated patch . It seems to be working fine and applies cleanly
. However I have one minor concern before I apply it - The overlay div while clicking on any
button which would create a form like "Register Template" , "Add Network" etc seems to have
been affected . It has changed from a light bluish to a complete black background. Can you
investigate this minor issue and rectify this problem as well before I apply your patch.
> > 
> > Thanks once again,
> > Pranav

Hi Pranav,
          I've noticed the side effect you mentioned.  Thanks for giving me a chance to investigate
this problem. I'll rectify it as soon as possible.

Regards

Isaac


- Isaac


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8992/#review15643
-----------------------------------------------------------


On Jan. 24, 2013, 1:58 p.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8992/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 1:58 p.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> The patch is to resolve CLOUDSTACK-965 issue which prevents from showing the error message
and dialog form in the mean time.
> 
> 
> This addresses bug CLOUDSTACK-965.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/ui/dialog.js 5236bb6 
> 
> Diff: https://reviews.apache.org/r/8992/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message