cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranav Saxena" <pranav.sax...@citrix.com>
Subject Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time
Date Thu, 24 Jan 2013 10:38:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8992/#review15638
-----------------------------------------------------------


Hey Isaac, 

I reviewed your patch but it seems there is some problem with your variable declaration. After
having applied your patch (no whitespace errors this time) , there is an error which is thrown
on firebug stating that one of the variables is not defined - 

f is undefined
[Break On This Error] 	

if(f.select || f.dynamic){

Could you please rectify this and submit the patch again ?

Thanks
Pranav


- Pranav Saxena


On Jan. 21, 2013, 12:04 p.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8992/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2013, 12:04 p.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> The patch is to resolve CLOUDSTACK-965 issue which prevents from showing the error message
and dialog form in the mean time.
> 
> 
> This addresses bug CLOUDSTACK-965.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/ui/dialog.js 5236bb6 
> 
> Diff: https://reviews.apache.org/r/8992/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message