cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurelien DE FANTI" <a_defa...@yahoo.fr>
Subject Re: Review Request: maven: add mysql version reference to enable non-snapshot builds
Date Thu, 17 Jan 2013 21:17:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8815/#review15466
-----------------------------------------------------------


Why are you adding mysql-connector-java version in children pom ?
The version is already set in cloudstack pom (look at dependencyManagement section). It's
to simplify pom files that version is only declared in parent pom (the same example was shown
in chapter 3.4 "Maven: The Complete Reference" book)

- Aurelien DE FANTI


On Jan. 4, 2013, 2:33 p.m., Noa Resare wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8815/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 2:33 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> If you update your build to build a version with a name not ending in -SNAPSHOT, you
are required to declare versions on all your depdendencies. There is already a cs.mysql.version
property, this patch makes sure it is used where appropriate.
> 
> 
> This addresses bug CLOUDSTACK-771.
> 
> 
> Diffs
> -----
> 
>   awsapi/pom.xml 06c9d7e 
>   client/pom.xml 7707706 
>   server/pom.xml 5ae926f 
>   utils/pom.xml 1ee8b7e 
> 
> Diff: https://reviews.apache.org/r/8815/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Noa Resare
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message