cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-297 Reset SSH key to access VM (Similar to reset password)
Date Thu, 17 Jan 2013 13:52:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8905/
-----------------------------------------------------------

(Updated Jan. 17, 2013, 1:52 p.m.)


Review request for cloudstack and Abhinandan Prateek.


Changes
-------

Uploaded the new diff with all fixes.


Description
-------

A user VM can be associated with a SSH key pair while deploying that VM. A user can SSH into
the VM using the SSH private Key. 
using this feature we can reset that SSH key pair corresponding to that VM, i.e., to associate
a new SSH key pair to the VM.


This addresses bug CLOUDSTACK-297.


Diffs (updated)
-----

  api/src/com/cloud/event/EventTypes.java 87eddca 
  api/src/com/cloud/network/element/UserDataServiceProvider.java 321ccc7 
  api/src/com/cloud/vm/UserVmService.java b1ebe10 
  api/src/org/apache/cloudstack/api/command/user/vm/ResetVMSSHKeyCmd.java PRE-CREATION 
  client/tomcatconf/commands.properties.in 182cbd8 
  server/src/com/cloud/network/NetworkManager.java 0ca28f8 
  server/src/com/cloud/network/NetworkManagerImpl.java 0a1fcd7 
  server/src/com/cloud/network/element/CloudZonesNetworkElement.java ae8be0d 
  server/src/com/cloud/network/element/VirtualRouterElement.java 02a239e 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 2980871 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 717da05 
  server/src/com/cloud/vm/UserVmManagerImpl.java a6fbdb1 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 28d1a60 
  server/test/com/cloud/vm/MockUserVmManagerImpl.java 27508b1 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java 642ea10 

Diff: https://reviews.apache.org/r/8905/diff/


Testing
-------

I did the manual testing
- Reset SSH keys for VM  already having SSH key
- Reset SSH keys for VM  created from password enabled template and already having SSH key

- Reset SSH keys for VM  having no SSH key
- Reset SSH keys for VM  created from password enabled template and have no previous SSH key
- Reset SSH keys for VM  already having SSH key when VM is in running state
- Reset SSH keys for VM  created from password enabled template and already having SSH key
 and VM is in running state


Thanks,

Harikrishna Patnala


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message